Launchpad itself

Instruction 'Yes, define new tag' is misleading

Bug #87058 reported by Chris Kenyon
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jamal Fanaian
Launchpad itself 10.01

Bug Description

The message suggests that if you click you will enter the definition of the new tag. I have waited a couple of times expecting a pop up only and assumed it was not appearing due to a pop up blocker.

Given the present functionality (which is excellent) should it be worded as 'Yes, define this as a new tag'?

Additionally, should previously used tags show up when you are deciding to add a tag?

Tags: bugtag lp-bugs

Related branches

lp:~jamalta/launchpad/newtag-statement-redundancy
Brad Crittenden (community): Approve (code)
Curtis Hovey (community): Approve (ui)
Diff: 121 lines (+13/-15)
5 files modified
lib/lp/bugs/browser/bug.py (+2/-3)
lib/lp/bugs/browser/tests/bug-views.txt (+3/-3)
lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt (+3/-3)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+2/-2)
lib/lp/bugs/stories/bugs/xx-bug-edit.txt (+3/-4)
lp:~bac/launchpad/jamalta-bug-106924 (Merged)
Matthew Paul Thomas (mpt)
Changed in malone:
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
Joey Stanford (joey) wrote :

Hi Chris,

Presently there is a button which states "Yes, define new tag":

"The tag "<tagname>" hasn't yet been used by Launchpad Bugs before. Is this a new tag? [Yes, define new tag]"

Does this resolve the first part of this concern?

The comment about displaying / choosing existing tags I'll leave to the bugs team.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

That message hasn't been changed since 2006-08-29, and this bug was reported on 2007-02-22.

See also bug 106924.

Revision history for this message
Jamal Fanaian (jamalta) wrote :

This validation only occurs when modifying tags from the bug's +edit page. There is no confirmation when editing tags in-line.

Same for bug #106924.

Revision history for this message
Jamal Fanaian (jamalta) wrote :

What would be the suggested way of rewriting the statement? Would this work?

'The tag "<tagname>" hasn't been used by <targetname> before. [Define as a new tag]'

Changed in malone:
assignee: nobody → Jamal Fanaian (jamalta)
Revision history for this message
Jamal Fanaian (jamalta) wrote :

Also, what is the recommendation on displaying other tags? If so, what would be the criteria to filter the displayed tags by? Or are we displaying all the tags? Thanks!

Revision history for this message
Brad Crittenden (bac) wrote :

I propose changing the message when not using Javascript to:

The tag "superdupernewtag" hasn't been used by Launchpad Bugs before. (Create the new tag)

This fix solves the grammatical issues raised in bug 106924 and the use of the verb "create" rather than "define" should solve Chris' issue.

It is interesting to note that the Ajax version just creates it without asking.

Revision history for this message
Brad Crittenden (bac) wrote :

Commited in devel r 10204

Changed in malone:
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
Changed in malone:
milestone: none → 10.01
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.