Comment 2 for bug 549310

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Sounds like a good idea since a warning will not block anyone and help
> people that want to share their code realize that email maybe the only
> way to reach them.
>
> ** Changed in: bzr
> Status: New => Confirmed
>
> ** Changed in: bzr
> Importance: Undecided => Wishlist
>
> ** Tags added: easy
>

We've had people complain about it requiring emails before...

'bzr whoami' does have the code:
        try:
            config.extract_email_address(name)
        except errors.NoEmailInUsername, e:
            warning('"%s" does not seem to contain an email address. '
                    'This is allowed, but not recommended.', name)

We could *probably* extend that to also checking if there is a '.' in
the email address.

However, I have a very strong feeling that people who are committing
with "<joe@host>" are actually *never* running 'bzr whoami', and we are
just inferring their username from the system.

So we would have to complain at some other time (like every time the
user tries to commit). This is sort of fallout of a decision to minimize
the number of steps you need to do to 'get going'. We could:

1) Abort if we need a username and the user has not supplied one.
  a) Only do this for 'commit' style actions
  b) Also do this for 'checkout', since we use the user info in the
     'lock' file to indicate to other people who locked this.
2) Give a warning whenever we guess an identity, rather than an
   explicitly stated one. (Also subject to a & b)
3) Give a warning if we use an guessed identity, but it doesn't quite
   fit what we think a real one should look like. (No User, no '.' in
   email, etc.)
4) Just use the guessed identity (status quo).

I might be ok with "2a". Warn if we are guessing the user identity
during commit, but don't warn for stuff like lock files. Certainly many
of us have a "foo@newmachine" commit in our history.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuuC3MACgkQJdeBCYSNAAO8ggCg0jjYVL6jYovv9P1T4gMGNatW
3eAAnAxsMcTddN81YksxqJhEq2h9m/uu
=bxIH
-----END PGP SIGNATURE-----