Ubuntu
firefox package

  1. Bug #744580
  2. Comment #17

Comment 17 for bug 744580

Revision history for this message
In , Chris Coulson (chrisccoulson) wrote :

(In reply to comment #10)
> + nscoord oneDevPixel = presContext->DevPixelsToAppUnits(1);
> + nsPoint offsetPoint = aPoint - nsPoint(oneDevPixel * 20, oneDevPixel * 20);
> + nsSize rectSize = nsSize(oneDevPixel * 40, oneDevPixel * 40);
> PRBool didScroll = presContext->PresShell()->
> + ScrollFrameRectIntoView(aFrame, nsRect(offsetPoint, rectSize),
>
> Why not
> nsRect r = nsIntRect(-20, -20, 40, 40).
> ToAppUnits(presContext->AppUnitsPerDevPixel());
> PRBool didScroll = presContext->PresShell()->
> ScrollFrameRectIntoView(aFrame, r + aPoint);
>
> Sure looks simpler to me!

Yes, you're right. Thanks!