One other thing I stumbled over is this snippet below. I just wonder whether the handle should not be set to -1 before bailing out in case of init failing.
virDrvOpenStatus
xenHypervisorOpen(virConnectPtr conn, virConnectAuthPtr auth ATTRIBUTE_UNUSED, unsigned int flags)
{
int ret;
xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) conn->privateData;
One other thing I stumbled over is this snippet below. I just wonder whether the handle should not be set to -1 before bailing out in case of init failing.
virDrvOpenStatus en(virConnectPt r conn,
virConnectA uthPtr auth ATTRIBUTE_UNUSED,
unsigned int flags) rivatePtr priv = (xenUnifiedPriv atePtr) conn->privateData;
xenHypervisorOp
{
int ret;
xenUnifiedP
virCheckFla gs(VIR_ CONNECT_ RO, VIR_DRV_ OPEN_ERROR) ;
if (initialized == 0) nit(NULL) == -1)
if (xenHypervisorI
return -1;
priv->handle = -1;