Comment 10 for bug 361788

Revision history for this message
Sebastian Pipping (webmaster-hartwork) wrote :

Applied you patch and updated my system to GTK+ 2.14. Now compilation fails with

===============================
cc1: warnings being treated as errors
dnd.c: In function âdnd_is_xscreensaver_activeâ:
dnd.c:75: warning: dereferencing type-punned pointer will break strict-aliasing rules
===============================

I suggest to ..
0) fix the cause of that warning
1) remove harcoded "-Werror" from <configure.in> and <tests/Makefile.am>
2) remove hardcoded "-std=c99" from the same two files, use Autoconf's macro AC_PROG_CC_C99 instead
3) run "./configure --enable-compile-warnings=error" on your end when warning-to-error conversion is wanted. Some Gnome macro notify-osd uses pulls that in. I guess you overlooked it.
4) fix former or integration of it to notify-osd. at least for me after applying (1) compilation did not fail as expected.

Looking forward to your feedback.