Comment 9 for bug 538580

Revision history for this message
Charles Kerr (charlesk) wrote :

Actually I think you're right.

The problem seems to have been introduced in r10075, where we make the default `full' allocation if fallocate64() is present on the system. The previous default was `fast'. r10075 was a bad idea, since *having* fallocate64() on your system is no guarantee that fallocate64() will actually succeed for your filesystem when it's invoked, and if it fails, things will still be slow.

r10337 fixes this in a way that fails more gracefully. since 1.92 is based off r10363 it has both of these patches, so fixing this for 10.04 is a simple/safe fix of backing out r10075 s.t. we always use `fast' as the default instead of doing an #ifdef HAVE_FALLOCATE64 ... `full' #else ... `fast' #endif

Here is the patch to back out r10075: http://trac.transmissionbt.com/changeset/10463

This isn't a showstopper for 10.04, but IMO it would be good to have and is a safe, unambiguous fix.