Comment 2 for bug 506800

Revision history for this message
Connor Imes (ckimes) wrote :

Gilbert, this patch looks very nice, thanks so much for your hard work. Here are my comments, they are simple and easy to fix:

It seems that you didn't validate correctly:
   scripts/validate.sh serverguide/C/serverguide.xml
It shows that the section dns-configuration already exists in the dns.xml file. I suggest changing the name to dns-client-configuration.

Typos:
  Flusing -> Flushing
  as show -> as shown
  resovle -> resolve

I see that you have multiple notes referencing the man page for interfaces(5) - one of which also references dhclient(8). These may be better placed in one location - in the Resources section at the bottom of the page. You may also consider linking them to manpages.ubuntu.com using the variable "&distro-codename-short;" so the links stay up to date.

Another string, "keep them left to their default values" is a little strange, consider touching it up. "keep them left" just doesn't sound right.

As for your question about the "70-persistent-net.rules" file, if it is valid to wrap the entries in the configuration file, you can do so in the docs as well. However, if each entry has to be on one line, then we should leave it as so.