Comment 57 for bug 1013171

Revision history for this message
Edward Donovan (edward.donovan) wrote :

chromium-browser has three different things that need to be changed, in its apport hook. The print and except statements, I understand what to do. The third issue is a list comprehension, I think. It looked like this:

    for ext in entry['extensions']['settings'].keys():

The 2to3 tool wants to wrap that in "list()" :

    for ext in list(entry['extensions']['settings'].keys()):

That looks fair enough, according to the python 3 docs. But I don't really know why this line needs fixing, while

    for plugin in entry['plugins']['plugins_list']:

does not. I can see that the former line has a method call or something, with ".keys()". But since I can't tell you why those are treated differently, I'd better ask for someone more knowledgeable to look at this. Thanks.