lp:~3v1n0/sni-qt/icons-user-cache-on-snap

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:sni-qt at revision 103

Lukáš Tinkl (community): Approve on 2016-11-22

Diff: 149 lines (+57/-10)

5 files modified

src/fsutils.cpp (+16/-4)
src/iconcache.cpp (+11/-2)
src/iconcache.h (+2/-2)
src/statusnotifieritem.cpp (+1/-1)
tests/auto/iconcachetest.cpp (+27/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1600136: App indicator does not show icon for Qt apps or with custom icons

High

Fix Released

Link a bug report

Related blueprints

109. By Marco Trevisan (Treviño) on 2016-11-16

IconCache: try to get $XDG_DATA_HOME as base icon folders

108. By Marco Trevisan (Treviño) on 2016-11-16

fsutils: add some comments about how we get the .cache

107. By Marco Trevisan (Treviño) on 2016-11-16

Don't use deprecated QDir::separator()

106. By Marco Trevisan (Treviño) on 2016-11-16

Fsutils: cleanup the snap path computation

105. By Marco Trevisan (Treviño) on 2016-11-16

IconCache: get the proper theme path based on the fact we're using a themed icon or not

If an app uses QIcon::fromTheme then we only have the icon name of it, and thus we need
to return a valid icon theme path. Now, it's not possible to return the whole list of dirs,
so we just fallback to the home icons folder, so that users might in case add icons there.

In $SNAP world, when using desktop-launcher ~/.local/share/icons also contains all the themes
in from /usr/share/icons and potentially more (depending on the wrapper used for launching)
so, we can be quite flexible with it.

104. By Marco Trevisan (Treviño) on 2016-11-15

fsutils: when running in a snap, save icons in $XDG_CACHE_HOME

Or in the user cache, but still in an indicator readable location

103. By Marco Trevisan (Treviño) on 2016-11-15

StatusNotifierItem: only apply setAppUserTime workaround in Unity

102. By Marco Trevisan (Treviño) on 2016-11-15

statusnotifieritem: reset app usertime on activation to ensure compiz will raise it

101. By CI Train Bot Account on 2015-07-29

Releasing 0.2.7+15.10.20150729-0ubuntu1

100. By Alberts Muktupāvels on 2015-07-29

Fix RegisterStatusNotifier method call to match specification.
Approved by: Dmitry Shachnev, Łukasz Zemczak