DBus Menu

Merge lp:~aacid/libdbusmenu/compile-with-clang into lp:libdbusmenu/13.04

  1. compile-with-clang
  2. Merge into trunk.13.04
Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp:~aacid/libdbusmenu/compile-with-clang
Merge into: lp:libdbusmenu/13.04
Diff against target: 37 lines (+5/-5)
2 files modified
libdbusmenu-glib/menuitem.c (+2/-2)
libdbusmenu-glib/server.c (+3/-3)
To merge this branch: bzr merge lp:~aacid/libdbusmenu/compile-with-clang
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Disapprove
Charles Kerr (community) Needs Information
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+131573@code.launchpad.net

Commit message

Compile with clang

clang complains that using name: value is a gnu extension

Description of the change

compile with clang

clang complains that using name: value is a gnu extension

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:433
http://jenkins.qa.ubuntu.com/job/dbusmenu-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dbusmenu-ci/./build=pbuilder,distribution=quantal,flavor=amd64/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dbusmenu-ci/./build=pbuilder,distribution=quantal,flavor=i386/4/console

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

I'm not sure that I like this.

What if we replace the gcc syntax with c99 syntax? aacid, does lp:~charlesk/dbusmenu/compile-with-clang compile on clang?

review: Needs Information
Revision history for this message
Albert Astals Cid (aacid) wrote :

Yes, it does, want me to discard this request?

Revision history for this message
Charles Kerr (charlesk) wrote :

So, go ahead and review https://code.launchpad.net/~charlesk/dbusmenu/compile-with-clang/+merge/131599 to make it official and Jenkins will merge it.

Also if you're using clang and have time to experiment, could you see if clang's static analyzer finds anything useful on dbusmenu? :)

Revision history for this message
Albert Astals Cid (aacid) wrote :

Using https://code.launchpad.net/~charlesk/dbusmenu/compile-with-clang/+merge/131599 instead

review: Disapprove
Revision history for this message
Albert Astals Cid (aacid) wrote :

Did run the static analyzer, found one thing that was actually a false positive

Unmerged revisions

433. By Albert Astals Cid

Compile with clang

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/menuitem.c'
2--- libdbusmenu-glib/menuitem.c 2012-10-07 15:35:50 +0000
3+++ libdbusmenu-glib/menuitem.c 2012-10-26 10:29:26 +0000
4@@ -974,7 +974,7 @@
5 }
6 return mi;
7 }
8- find_id_t find_id = {mi: NULL, id: id};
9+ find_id_t find_id = {/*mi:*/ NULL, /*id:*/ id};
10 find_id_helper(mi, &find_id);
11 return find_id.mi;
12 }
13@@ -1712,7 +1712,7 @@
14
15 func(mi, data);
16 GList * children = dbusmenu_menuitem_get_children(mi);
17- foreach_struct_t foreach_data = {func: func, data: data};
18+ foreach_struct_t foreach_data = {/*func:*/ func, /*data:*/ data};
19 g_list_foreach(children, foreach_helper, &foreach_data);
20 return;
21 }
22
23=== modified file 'libdbusmenu-glib/server.c'
24--- libdbusmenu-glib/server.c 2012-10-07 15:35:50 +0000
25+++ libdbusmenu-glib/server.c 2012-10-26 10:29:26 +0000
26@@ -215,9 +215,9 @@
27 static GDBusNodeInfo * dbusmenu_node_info = NULL;
28 static GDBusInterfaceInfo * dbusmenu_interface_info = NULL;
29 static const GDBusInterfaceVTable dbusmenu_interface_table = {
30- method_call: bus_method_call,
31- get_property: bus_get_prop,
32- set_property: NULL /* No properties that can be set */
33+ /*method_call:*/ bus_method_call,
34+ /*get_property:*/ bus_get_prop,
35+ /*set_property:*/ NULL /* No properties that can be set */
36 };
37 static method_table_t dbusmenu_method_table[METHOD_COUNT];
38

Subscribers

People subscribed via source and target branches