qmenumodel

Merge lp:~aacid/qmenumodel/add_return into lp:qmenumodel

  1. add_return
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Michael Zanetti
Approved revision: 133
Merged at revision: 133
Proposed branch: lp:~aacid/qmenumodel/add_return
Merge into: lp:qmenumodel
Diff against target: 11 lines (+1/-0)
1 file modified
libqmenumodel/src/unitymenumodel.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/qmenumodel/add_return
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Review via email: mp+321668@code.launchpad.net

Commit message

Add a return true

No one seems to be actually using the returned bool, but it's always nice to have a return

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

agreed

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libqmenumodel/src/unitymenumodel.cpp'
2--- libqmenumodel/src/unitymenumodel.cpp 2017-03-16 16:55:30 +0000
3+++ libqmenumodel/src/unitymenumodel.cpp 2017-04-03 08:19:15 +0000
4@@ -685,6 +685,7 @@
5 extendedAttrs, freeExtendedAttrs);
6
7 Q_EMIT dataChanged(index(position, 0), index(position, 0), QVector<int>() << ExtendedAttributesRole);
8+ return true;
9 }
10
11 QVariant UnityMenuModel::get(int row, const QByteArray &role)

Subscribers

People subscribed via source and target branches