Merge lp:~abentley/launchpad/allow-0.3 into lp:launchpad
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Aaron Bentley | ||||
Proposed branch: | lp:~abentley/launchpad/allow-0.3 | ||||
Merge into: | lp:launchpad | ||||
Prerequisite: | lp:~abentley/launchpad/safe-v3 | ||||
Diff against target: |
205 lines (+26/-20) 5 files modified
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+5/-5) lib/lp/code/interfaces/sourcepackagerecipe.py (+1/-1) lib/lp/code/model/sourcepackagerecipedata.py (+2/-2) lib/lp/code/model/tests/test_recipebuilder.py (+2/-2) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+16/-10) |
||||
To merge this branch: | bzr merge lp:~abentley/launchpad/allow-0.3 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Disapprove | ||
Paul Hummer (community) | Approve | ||
Review via email: mp+34478@code.launchpad.net |
Commit message
Fix bug #479705
Description of the change
= Summary =
Fix bug #479705
== Proposed fix ==
Support recipe format 0.3, which supports nest-part
== Pre-implementation notes ==
None
== Implementation details ==
Made 0.3 the default everywhere, so that if people choose to add a nest-part
command to the default template, it will just work.
== Tests ==
bin/test test_sourcepack
== Demo and Q/A ==
Create a recipe that uses 0.3 and nest-part. If it builds, correctly, this
worked.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/canonical
lib/canonical
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
168: E202 whitespace before ')'
./lib/lp/
285: E231 missing whitespace after ','
309: E231 missing whitespace after ','
317: E231 missing whitespace after ','
324: E231 missing whitespace after ','
332: E231 missing whitespace after ','
370: E231 missing whitespace after ','
430: E231 missing whitespace after ','
510: E301 expected 1 blank line, found 0
731: Line exceeds 78 characters.
./lib/canonical
11: Line exceeds 78 characters.
./lib/lp/
275: E231 missing whitespace after ','
./lib/lp/
77: E231 missing whitespace after ','
154: E202 whitespace before ')'
154: E231 missing whitespace after ','
./lib/lp/
169: E501 line too long (82 characters)
176: E501 line too long (80 characters)
203: E501 line too long (80 characters)
245: E301 expected 1 blank line, found 2
82: Line exceeds 78 characters.
169: Line exceeds 78 characters.
176: Line exceeds 78 characters.
203: Line exceeds 78 characters.
Superseded by https:/ /code.edge. launchpad. net/~abentley/ launchpad/ allow-0. 3-2/+merge/ 39562