Merge lp:~abentley/launchpad/answer-ordering into lp:launchpad

Proposed by Aaron Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~abentley/launchpad/answer-ordering
Merge into: lp:launchpad
Diff against target: 21 lines (+2/-2)
1 file modified
lib/lp/answers/doc/questiontarget.txt (+2/-2)
To merge this branch: bzr merge lp:~abentley/launchpad/answer-ordering
Reviewer Review Type Date Requested Status
Paul Hummer (community) code Approve
Review via email: mp+23050@code.launchpad.net

Commit message

Fix test ordering issue.

Description of the change

= Summary =
Fix ordering issue in test.

== Proposed fix ==
Sort list of people by person name..

== Pre-implementation notes ==
None

== Implementation details ==
None

== Tests ==
bin/test -t questiontarget.txt

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/answers/doc/questiontarget.txt

== Pyflakes Doctest notices ==

'target' appears to be a predefined value invisible to pyflakes.

lib/lp/answers/doc/questiontarget.txt
    22: undefined name 'target'
    45: undefined name 'target'
    80: undefined name 'target'
    90: undefined name 'target'
    103: undefined name 'target'
    109: undefined name 'target'
    111: undefined name 'target'
    130: undefined name 'target'
    151: undefined name 'target'
    166: undefined name 'target'
    182: undefined name 'target'
    194: undefined name 'target'
    202: undefined name 'target'
    220: undefined name 'target'
    231: undefined name 'target'
    246: undefined name 'target'
    262: undefined name 'target'
    279: undefined name 'target'
    292: undefined name 'target'
    296: undefined name 'target'
    331: undefined name 'target'
    344: undefined name 'target'
    358: undefined name 'target'
    370: undefined name 'target'
    380: undefined name 'target'
    387: undefined name 'target'
    396: undefined name 'target'
    398: undefined name 'target'
    403: undefined name 'target'
    408: undefined name 'target'
    417: undefined name 'target'
    426: undefined name 'target'
    428: undefined name 'target'
    430: undefined name 'target'
    432: undefined name 'target'
    438: undefined name 'target'
    453: undefined name 'target'
    467: undefined name 'target'
    479: undefined name 'target'
    488: undefined name 'target'
    501: undefined name 'target'
    506: undefined name 'target'
    521: undefined name 'target'

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/answers/doc/questiontarget.txt'
2--- lib/lp/answers/doc/questiontarget.txt 2010-02-04 04:56:49 +0000
3+++ lib/lp/answers/doc/questiontarget.txt 2010-04-08 20:33:20 +0000
4@@ -504,7 +504,7 @@
5 carlos
6
7 >>> answer_contacts = target.getAnswerContactsForLanguage(english)
8- >>> for person in answer_contacts:
9+ >>> for person in sorted(answer_contacts, key=lambda person: person.name):
10 ... print person.name
11 carlos
12 daf
13@@ -532,7 +532,7 @@
14
15 >>> from datetime import datetime
16 >>> from pytz import UTC
17- >>> from lp.bugs.interfaces.bug import CreateBugParams, IBugSet
18+ >>> from lp.bugs.interfaces.bug import CreateBugParams
19 >>> from lp.registry.interfaces.product import IProductSet
20
21 >>> now = datetime.now(UTC)