Merge lp:~abentley/launchpad/disable-recipe-builds into lp:launchpad/db-devel

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 9407
Proposed branch: lp:~abentley/launchpad/disable-recipe-builds
Merge into: lp:launchpad/db-devel
Diff against target: 27 lines (+4/-2)
2 files modified
lib/canonical/config/schema-lazr.conf (+1/-1)
lib/lp/code/templates/branch-index.pt (+3/-1)
To merge this branch: bzr merge lp:~abentley/launchpad/disable-recipe-builds
Reviewer Review Type Date Requested Status
Curtis Hovey (community) rc Approve
Review via email: mp+26322@code.launchpad.net

Commit message

Disable source package recipe builds UI via config.

Description of the change

= Summary =
Disable source package recipe builds on production

== Proposed fix ==
Disable the build_from_branch.enabled flag. Fix the one template that wasn't
respecting it.

Once this is cherrypicked, we can selectively restore source pakcage recipe
builds on edge with a landing to lp-production-configs.

== Pre-implementation notes ==
Discussed w/ sinzui and rockstar

== Implementation details ==
None

== Tests ==
None

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/config/schema-lazr.conf
  lib/lp/code/templates/branch-index.pt

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

This is good to land.

review: Approve (rc)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/config/schema-lazr.conf'
2--- lib/canonical/config/schema-lazr.conf 2010-05-18 15:21:49 +0000
3+++ lib/canonical/config/schema-lazr.conf 2010-05-28 16:23:33 +0000
4@@ -167,7 +167,7 @@
5
6
7 [build_from_branch]
8-enabled = True
9+enabled = False
10
11
12 # Configuration for spawned Bazaar subprocesses.
13
14=== modified file 'lib/lp/code/templates/branch-index.pt'
15--- lib/lp/code/templates/branch-index.pt 2010-05-22 04:19:57 +0000
16+++ lib/lp/code/templates/branch-index.pt 2010-05-28 16:23:33 +0000
17@@ -107,7 +107,9 @@
18 <tal:branch-pending-merges
19 replace="structure context/@@++branch-pending-merges" />
20 <tal:branch-recipes
21- replace="structure context/@@++branch-recipes" />
22+ replace="structure context/@@++branch-recipes"
23+ condition="modules/canonical.config/config/build_from_branch/enabled"
24+ />
25 <tal:related-bugs-specs
26 replace="structure context/@@++branch-related-bugs-specs" />
27 </div>

Subscribers

People subscribed via source and target branches

to status/vote changes: