Merge lp:~abentley/launchpad/fix-groupby into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 11628 |
Proposed branch: | lp:~abentley/launchpad/fix-groupby |
Merge into: | lp:launchpad |
Diff against target: |
40 lines (+7/-6) 2 files modified
lib/lp/code/model/branchmergeproposal.py (+1/-6) lib/lp_sitecustomize.py (+6/-0) |
To merge this branch: | bzr merge lp:~abentley/launchpad/fix-groupby |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+36360@code.launchpad.net |
Commit message
Fix use of itertools.groupby through security proxies.
Description of the change
= Summary =
Prevent SecurityProxy from erroring when itertools.groupby is used.
== Proposed fix ==
Handle itertools.groupby like other built-in iterators.
== Pre-implementation notes ==
Pre-implementation was with gary
== Implementation details ==
_iteratorChecker is used for built-in python iterators. A shame it's got an
underscored name.
I guess I could phrase it this way:
checker.
But that only gets rid of the underscore, not the underlying problem that this
checker is not provided as a public interface.
== Tests ==
bin/test -t test_include_
== Demo and Q/A ==
None
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp_
./lib/lp_
22: E302 expected 2 blank lines, found 1
27: E302 expected 2 blank lines, found 1
37: E302 expected 2 blank lines, found 1
Looks good.