Merge lp:~abentley/launchpad/force-aptitude into lp:launchpad

= Summary =
Fix bug #599102 Source build based on recipe targeting Maverick fails

== Proposed fix ==
Add aptitude to the list of packages to install, because pbuilder's scripts
need it but the package doesn't depend on it.

== Pre-implementation notes ==
Mid-implementation discussion with Lamont.

== Implementation details ==
Also made some changes to make this kind of fix easier to test, updating the
test script to use Maverick, and adding Maverick to the soyuz-sampledata-setup
script.

Also improved logging by displaying the recipe being built and the command
being run.

Also updated the sudo command to specify -i so that it behaves more like the
user.

== Tests ==
None (but it has been interactively tested on dogfood.)

== Demo and Q/A ==
Request a recipe build targetting Maverick. It should not die due to lack of
aptitude.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  utilities/soyuz-sampledata-setup.py
  lib/canonical/buildd/buildrecipe
  lib/canonical/buildd/test_buildd_recipe

== Pylint notices ==

C
    1: Invalid name "soyuz-sampledata-setup" (should match (([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$)

E
    33: No name 'component' in module 'zope'

F
    33: Unable to import 'zope.component'

E
    35: No name 'lifecycleevent' in module 'zope'

F
    35: Unable to import 'zope.lifecycleevent'

E
    36: No name 'security' in module 'zope'

F
    36: Unable to import 'zope.security.proxy'

C
    65: Invalid name "user_name" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    66: Invalid name "default_email" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    145:retire_active_publishing_histories: Invalid name "retire_active_publishing_histories" (should match [a-z_][a-z0-9_]{2,30}$)
    285:clean_up: Missing docstring

W
    307:set_source_package_format: Redefining built-in 'format'
    312:populate: Unused argument 'options'
    363:create_ppa_user: Unused variable 'stdout'
    349:create_ppa_user: Unused argument 'approver'

C
    389:main: Missing docstring

W
    390:main: Unused variable 'args'

    Report
    ======
    191 statements analysed.

    Duplication
    -----------

    +-------------------------+------+---------+-----------+
    | |now |previous |difference |
    +=========================+======+=========+===========+
    |nb duplicated lines |0 |NC |NC |
    +-------------------------+------+---------+-----------+
    |percent duplicated lines |0.000 |NC |NC |
    +-------------------------+------+---------+-----------+

    Raw metrics
    -----------

    +----------+-------+------+---------+-----------+
    |type |number |% |previous |difference |
    +==========+=======+======+=========+===========+
    |code |243 |66.21 |NC |NC |
    +----------+-------+------+---------+-----------+
    |docstring |60 |16.35 |NC |NC |
    +----------+-------+------+---------+-----------+
    |comment |22 |5.99 |NC |NC |
    +----------+-------+------+---------+-----------+
    |empty |42 |11.44 |NC |NC |
    +----------+-------+------+---------+-----------+

    External dependencies
    ---------------------
    ~~:
    :

    _pythonpath (soyuz-sampledata-setup)
    canonical
    -database
    | -sqlbase
    | -sqlvalues (soyuz-sampledata-setup)
    -launchpad
    | -interfaces
    | | -launchpad
    | | -ILaunchpadCelebrities (soyuz-sampledata-setup)
    | -scripts
    | | -execute_zcml_for_scripts (soyuz-sampledata-setup)
    | | -logger
    | | -logger (soyuz-sampledata-setup)
    | | -logger_options (soyuz-sampledata-setup)
    | -webapp
    | -interfaces
    | -IStoreSelector (soyuz-sampledata-setup)
    | -MAIN_STORE (soyuz-sampledata-setup)
    | -MASTER_FLAVOR (soyuz-sampledata-setup)
    | -SLAVE_FLAVOR (soyuz-sampledata-setup)
    -lp
    -initZopeless (soyuz-sampledata-setup)
    lp
    -registry
    | -interfaces
    | | -codeofconduct
    | | | -ISignedCodeOfConductSet (soyuz-sampledata-setup)
    | | -person
    | | | -IPersonSet (soyuz-sampledata-setup)
    | | -series
    | | -SeriesStatus (soyuz-sampledata-setup)
    | -model
    | -codeofconduct
    | -SignedCodeOfConduct (soyuz-sampledata-setup)
    -soyuz
    | -interfaces
    | | -component
    | | | -IComponentSet (soyuz-sampledata-setup)
    | | -processor
    | | | -IProcessorFamilySet (soyuz-sampledata-setup)
    | | -publishing
    | | | -active_publishing_status (soyuz-sampledata-setup)
    | | -section
    | | | -ISectionSet (soyuz-sampledata-setup)
    | | -sourcepackageformat
    | | -ISourcePackageFormatSelectionSet (soyuz-sampledata-setup)
    | | -SourcePackageFormat (soyuz-sampledata-setup)
    | -model
    | -component
    | | -ComponentSelection (soyuz-sampledata-setup)
    | -distroarchseries
    | | -DistroArchSeries (soyuz-sampledata-setup)
    | -section
    | -SectionSelection (soyuz-sampledata-setup)
    -testing
    -factory
    -LaunchpadObjectFactory (soyuz-sampledata-setup)
    optparse
    -OptionParser (soyuz-sampledata-setup)
    storm
    -store
    -Store (soyuz-sampledata-setup)
    textwrap
    -dedent (soyuz-sampledata-setup)
    transaction (soyuz-sampledata-setup)
    zope
    -event
    -notify (soyuz-sampledata-setup)

    Statistics by type
    ------------------

    +---------+-------+-----------+-----------+------------+---------+
    |type |number |old number |difference |%documented |%badname |
    +=========+=======+===========+===========+============+=========+
    |module |1 |NC |NC |100.00 |100.00 |
    +---------+-------+-----------+-----------+------------+---------+
    |class |1 |NC |NC |100.00 |0.00 |
    +---------+-------+-----------+-----------+------------+---------+
    |method |0 |NC |NC |0.00 |0.00 |
    +---------+-------+-----------+-----------+------------+---------+
    |function |22 |NC |NC |90.91 |4.55 |
    +---------+-------+-----------+-----------+------------+---------+

    Messages by category
    --------------------

    +-----------+-------+---------+-----------+
    |type |number |previous |difference |
    +===========+=======+=========+===========+
    |convention |6 |NC |NC |
    +-----------+-------+---------+-----------+
    |refactor |0 |NC |NC |
    +-----------+-------+---------+-----------+
    |warning |6 |NC |NC |
    +-----------+-------+---------+-----------+
    |error |3 |NC |NC |
    +-----------+-------+---------+-----------+

    Messages
    --------

    +-----------+------------+
    |message id |occurrences |
    +===========+============+
    |C0103 |4 |
    +-----------+------------+
    |F0401 |3 |
    +-----------+------------+
    |E0611 |3 |
    +-----------+------------+
    |W0613 |2 |
    +-----------+------------+
    |W0612 |2 |
    +-----------+------------+
    |C0111 |2 |
    +-----------+------------+
    |W0622 |1 |
    +-----------+------------+
    |W0611 |1 |
    +-----------+------------+

    Global evaluation
    -----------------
    Your code has been rated at 8.59/10