Launchpad itself

Merge lp:~abentley/launchpad/more-harness into lp:launchpad/db-devel

  1. more-harness
  2. Merge into db-devel
Proposed by Aaron Bentley
Status: Merged
Approved by: Māris Fogels
Approved revision: no longer in the source branch.
Merged at revision: 9999
Proposed branch: lp:~abentley/launchpad/more-harness
Merge into: lp:launchpad/db-devel
Diff against target: 18 lines (+3/-0)
1 file modified
lib/canonical/database/harness.py (+3/-0)
To merge this branch: bzr merge lp:~abentley/launchpad/more-harness
Reviewer Review Type Date Requested Status
Māris Fogels (community) Approve
Review via email: mp+41619@code.launchpad.net

Description of the change

= Summary =
Add useful stuff to harness

== Proposed fix ==
Add removeSecurityProxy, canonical_url, utc.

== Pre-implementation notes ==
None

== Implementation details ==
None

== Tests ==
None

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/database/harness.py

./lib/canonical/database/harness.py
      47: 'from storm.locals import *' used; unable to detect undefined names
      48: 'from storm.expr import *' used; unable to detect undefined names
      29: 'canonical_url' imported but unused
      49: 'DEFAULT_FLAVOR' imported but unused
      49: 'SLAVE_FLAVOR' imported but unused
      26: 'removeSecurityProxy' imported but unused
      22: 'utc' imported but unused
      23: 'transaction' imported but unused
      41: 'verifyObject' imported but unused
      44: 'rlcompleter' imported but unused
      71: E501 line too long (82 characters)
      71: Line exceeds 78 characters.

To post a comment you must log in.
Revision history for this message
Māris Fogels (mars) wrote :

Hi Aaron, this looks good. r=mars

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/database/harness.py'
2--- lib/canonical/database/harness.py 2010-11-08 13:23:22 +0000
3+++ lib/canonical/database/harness.py 2010-11-23 16:23:58 +0000
4@@ -19,11 +19,14 @@
5 import os
6 import sys
7
8+from pytz import utc
9 import transaction
10
11 from zope.component import getUtility
12+from zope.security.proxy import removeSecurityProxy
13
14 from canonical.launchpad.scripts import execute_zcml_for_scripts
15+from canonical.launchpad.webapp import canonical_url
16
17 from lp.answers.model.question import Question
18 from lp.blueprints.model.specification import Specification

Subscribers

People subscribed via source and target branches

to status/vote changes: