Launchpad itself

Merge lp:~abentley/launchpad/revert-enums into lp:launchpad

  1. revert-enums
  2. Merge into devel
Proposed by Aaron Bentley
Status: Merged
Approved by: Edwin Grubbs
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~abentley/launchpad/revert-enums
Merge into: lp:launchpad
Diff against target: 513 lines (+77/-68)
12 files modified
lib/lp/buildmaster/interfaces/buildbase.py (+6/-6)
lib/lp/code/browser/sourcepackagerecipe.py (+14/-4)
lib/lp/soyuz/doc/build-failedtoupload-workflow.txt (+1/-1)
lib/lp/soyuz/doc/build-notification.txt (+2/-2)
lib/lp/soyuz/doc/build.txt (+1/-1)
lib/lp/soyuz/doc/buildd-mass-retry.txt (+4/-4)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+6/-6)
lib/lp/soyuz/doc/gina.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-copy-packages.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-build-record.txt (+10/-11)
lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt (+30/-30)
lib/lp/soyuz/stories/soyuz/xx-private-builds.txt (+1/-1)
To merge this branch: bzr merge lp:~abentley/launchpad/revert-enums
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) Approve
Review via email: mp+23416@code.launchpad.net

Description of the change

= Summary =
Fix bug #559143:
  Build status title changes break API and uglify forms

== Proposed fix ==
Revert BuildStatus enum titles to previous values.

== Pre-implementation notes ==
Discussed with bigjools

== Implementation details ==
Various tests which had been updated to the new values had to be returned to
their previous state.

== Tests ==
bin/test -t browser test_sourcepackagerecipe
bin/test -t build-failedtoupload-workflow.txt -t build-notification.txt -t build.txt -t buildd-mass-retry.txt -t buildd-slavescanner.txt -t gina.txt -t xx-copy-packages.txt -t xx-build-record.txt -t xx-builds-pages.txt -t xx-private-builds.txt

== Demo and Q/A ==
https://edge.launchpad.net/ubuntu/+builds should show the old title values.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/doc/gina.txt
  lib/lp/soyuz/doc/buildd-slavescanner.txt
  lib/lp/soyuz/doc/build-failedtoupload-workflow.txt
  lib/lp/soyuz/stories/soyuz/xx-build-record.txt
  lib/lp/soyuz/stories/ppa/xx-copy-packages.txt
  lib/lp/soyuz/doc/build-notification.txt
  lib/lp/soyuz/stories/soyuz/xx-private-builds.txt
  lib/lp/soyuz/doc/buildd-mass-retry.txt
  lib/lp/code/browser/sourcepackagerecipe.py
  lib/lp/buildmaster/interfaces/buildbase.py
  lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt
  lib/lp/soyuz/doc/build.txt

== Pyflakes Doctest notices ==

lib/lp/soyuz/doc/buildd-slavescanner.txt
    689: local variable 'pub_binaries' is assigned to but never used

== Pylint notices ==

lib/lp/code/browser/sourcepackagerecipe.py
    11: [F0401] Unable to import 'canonical.launchpad.webapp'
    13: [F0401] Unable to import 'lp.buildmaster.interfaces.buildbase'

lib/lp/buildmaster/interfaces/buildbase.py
    17: [F0401] Unable to import 'zope.schema'
    18: [F0401] Unable to import 'lazr.enum'
    19: [F0401] Unable to import 'lazr.restful.declarations'
    20: [F0401] Unable to import 'lazr.restful.fields'
    22: [F0401] Unable to import 'lp.buildmaster.interfaces.builder'
    23: [F0401] Unable to import 'lp.buildmaster.interfaces.buildqueue'
    24: [F0401] Unable to import 'lp.registry.interfaces.distribution'
    25: [F0401] Unable to import 'lp.registry.interfaces.pocket'
    26: [F0401] Unable to import 'lp.soyuz.interfaces.archive'
    27: [F0401] Unable to import 'canonical.launchpad.interfaces.librarian'
    28: [F0401] Unable to import 'canonical.launchpad'

To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/buildmaster/interfaces/buildbase.py'
2--- lib/lp/buildmaster/interfaces/buildbase.py 2010-04-06 20:17:04 +0000
3+++ lib/lp/buildmaster/interfaces/buildbase.py 2010-04-19 03:44:25 +0000
4@@ -40,7 +40,7 @@
5 """
6
7 NEEDSBUILD = DBItem(0, """
8- Pending build
9+ Needs building
10
11 Build record is fresh and needs building. Nothing is yet known to
12 block this build and it is a candidate for building on any free
13@@ -48,7 +48,7 @@
14 """)
15
16 FULLYBUILT = DBItem(1, """
17- Successful build
18+ Successfully built
19
20 Build record is an historic account of the build. The build is complete
21 and needs no further work to complete it. The build log etc are all
22@@ -65,7 +65,7 @@
23 """)
24
25 MANUALDEPWAIT = DBItem(3, """
26- Could not build because of missing dependencies
27+ Dependency wait
28
29 Build record represents a package whose build dependencies cannot
30 currently be satisfied within the relevant DistroArchSeries. This
31@@ -74,7 +74,7 @@
32 """)
33
34 CHROOTWAIT = DBItem(4, """
35- Could not build because of chroot problem
36+ Chroot problem
37
38 Build record represents a build which needs a chroot currently known
39 to be damaged or bad in some way. The buildd maintainer will have to
40@@ -83,7 +83,7 @@
41 """)
42
43 SUPERSEDED = DBItem(5, """
44- Could not build because source package was superseded
45+ Build for superseded Source
46
47 Build record represents a build which never got to happen because the
48 source package release for the build was superseded before the job
49@@ -99,7 +99,7 @@
50 """)
51
52 FAILEDTOUPLOAD = DBItem(7, """
53- Could not be uploaded correctly
54+ Failed to upload
55
56 Build record is an historic account of a build that could not be
57 uploaded correctly. It's mainly genereated by failures in
58
59=== modified file 'lib/lp/code/browser/sourcepackagerecipe.py'
60--- lib/lp/code/browser/sourcepackagerecipe.py 2010-04-08 16:04:56 +0000
61+++ lib/lp/code/browser/sourcepackagerecipe.py 2010-04-19 03:44:25 +0000
62@@ -129,10 +129,20 @@
63 @property
64 def status(self):
65 """A human-friendly status string."""
66- if self.context.buildstate == BuildStatus.NEEDSBUILD:
67- if self.eta is None:
68- return 'No suitable builders'
69- return self.context.buildstate.title
70+ if (self.context.buildstate == BuildStatus.NEEDSBUILD
71+ and self.eta is None):
72+ return 'No suitable builders'
73+ return {
74+ BuildStatus.NEEDSBUILD: 'Pending build',
75+ BuildStatus.FULLYBUILT: 'Successful build',
76+ BuildStatus.MANUALDEPWAIT: (
77+ 'Could not build because of missing dependencies'),
78+ BuildStatus.CHROOTWAIT: (
79+ 'Could not build because of chroot problem'),
80+ BuildStatus.SUPERSEDED: (
81+ 'Could not build because source package was superseded'),
82+ BuildStatus.FAILEDTOUPLOAD: 'Could not be uploaded correctly',
83+ }.get(self.context.buildstate, self.context.buildstate.title)
84
85 @property
86 def eta(self):
87
88=== modified file 'lib/lp/soyuz/doc/build-failedtoupload-workflow.txt'
89--- lib/lp/soyuz/doc/build-failedtoupload-workflow.txt 2010-04-09 15:46:09 +0000
90+++ lib/lp/soyuz/doc/build-failedtoupload-workflow.txt 2010-04-19 03:44:25 +0000
91@@ -86,7 +86,7 @@
92 * Architecture: i386
93 * Archive: ubuntu primary archive
94 * Component: main
95- * State: Could not be uploaded correctly
96+ * State: Failed to upload
97 * Duration: a minute
98 * Build Log: http://launchpad.dev/ubuntu/+source/cdrkit/1.0/+build/22/+fil=
99 es/netapplet-1.0.0.tar.gz
100
101=== modified file 'lib/lp/soyuz/doc/build-notification.txt'
102--- lib/lp/soyuz/doc/build-notification.txt 2010-04-09 15:46:09 +0000
103+++ lib/lp/soyuz/doc/build-notification.txt 2010-04-19 03:44:25 +0000
104@@ -180,7 +180,7 @@
105 * Architecture: i386
106 * Archive: ubuntu primary archive
107 * Component: main
108- * State: Pending build
109+ * State: Needs building
110 * Duration: not available
111 * Build Log: not available
112 * Builder: not available
113@@ -316,7 +316,7 @@
114 * Architecture: i386
115 * Archive: ubuntu primary archive
116 * Component: main
117- * State: Could not build because source package was superseded
118+ * State: Build for superseded Source
119 * Duration: not available
120 * Build Log: not available
121 * Builder: not available
122
123=== modified file 'lib/lp/soyuz/doc/build.txt'
124--- lib/lp/soyuz/doc/build.txt 2010-04-12 08:29:02 +0000
125+++ lib/lp/soyuz/doc/build.txt 2010-04-19 03:44:25 +0000
126@@ -63,7 +63,7 @@
127 CHROOTWAIT, SUPERSEDED and FAILEDTOUPLOAD).
128
129 >>> firefox_build.buildstate
130- <DBItem BuildStatus.FULLYBUILT, (1) Successful build>
131+ <DBItem BuildStatus.FULLYBUILT, (1) Successfully built>
132
133 Builds which were already processed also offer additional information
134 about its process such as the time it was started and finished and its
135
136=== modified file 'lib/lp/soyuz/doc/buildd-mass-retry.txt'
137--- lib/lp/soyuz/doc/buildd-mass-retry.txt 2010-03-26 19:22:58 +0000
138+++ lib/lp/soyuz/doc/buildd-mass-retry.txt 2010-04-19 03:44:25 +0000
139@@ -40,9 +40,9 @@
140 DEBUG Intitialising connection.
141 INFO Initialising Build Mass-Retry for 'The Hoary Hedgehog Release/RELEASE'
142 INFO Processing builds in 'Failed to build'
143- INFO Processing builds in 'Could not build because of missing dependencies'
144+ INFO Processing builds in 'Dependency wait'
145 INFO Retrying i386 build of libstdc++ b8p in ubuntu hoary RELEASE (12)
146- INFO Processing builds in 'Could not build because of chroot problem'
147+ INFO Processing builds in 'Chroot problem'
148 INFO Success.
149 INFO Dry-run.
150 <BLANKLINE>
151@@ -62,8 +62,8 @@
152 DEBUG Intitialising connection.
153 INFO Initialising Build Mass-Retry for 'The Hoary Hedgehog Release for hppa (hppa)/RELEASE'
154 INFO Processing builds in 'Failed to build'
155- INFO Processing builds in 'Could not build because of missing dependencies'
156- INFO Processing builds in 'Could not build because of chroot problem'
157+ INFO Processing builds in 'Dependency wait'
158+ INFO Processing builds in 'Chroot problem'
159 INFO Success.
160 INFO Dry-run.
161 <BLANKLINE>
162
163=== modified file 'lib/lp/soyuz/doc/buildd-slavescanner.txt'
164--- lib/lp/soyuz/doc/buildd-slavescanner.txt 2010-04-12 16:23:13 +0000
165+++ lib/lp/soyuz/doc/buildd-slavescanner.txt 2010-04-19 03:44:25 +0000
166@@ -181,7 +181,7 @@
167 >>> build.dependencies
168 u'baz (>= 1.0.1)'
169 >>> build.buildstate.title
170- 'Could not build because of missing dependencies'
171+ 'Dependency wait'
172
173 WAITING - CHROOTFAIL -> the Chroot for this distroseries is damage, nor
174 builder, but right state stored in Build entry:
175@@ -208,7 +208,7 @@
176 >>> check_mail_sent(last_stub_mail_count)
177 True
178 >>> build.buildstate.title
179- 'Could not build because of chroot problem'
180+ 'Chroot problem'
181
182 WAITING - BUILDERFAIL -> builder has failed by internal error, job is available for next build round:
183
184@@ -235,7 +235,7 @@
185 False
186 >>> build = getUtility(IBinaryPackageBuildSet).getByQueueEntry(bqItem6)
187 >>> print build.buildstate.title
188- Pending build
189+ Needs building
190 >>> job = bqItem6.specific_job.job
191 >>> print job.status.title
192 Waiting
193@@ -356,7 +356,7 @@
194 >>> check_mail_sent(last_stub_mail_count)
195 True
196 >>> build.buildstate.title
197- 'Could not be uploaded correctly'
198+ 'Failed to upload'
199
200 Let's check the emails generated by this 'failure'
201 (see build-failedtoupload-workflow.txt for more information):
202@@ -447,7 +447,7 @@
203 >>> build.buildlog is not None
204 True
205 >>> build.buildstate.title
206- 'Successful build'
207+ 'Successfully built'
208 >>> check_mail_sent(last_stub_mail_count)
209 False
210
211@@ -485,7 +485,7 @@
212 False
213 >>> build = getUtility(IBinaryPackageBuildSet).getByQueueEntry(bqItem11)
214 >>> print build.buildstate.title
215- Pending build
216+ Needs building
217 >>> job = bqItem11.specific_job.job
218 >>> print job.status.title
219 Waiting
220
221=== modified file 'lib/lp/soyuz/doc/gina.txt'
222--- lib/lp/soyuz/doc/gina.txt 2010-04-13 06:57:14 +0000
223+++ lib/lp/soyuz/doc/gina.txt 2010-04-19 03:44:25 +0000
224@@ -366,7 +366,7 @@
225 >>> print ed.build.processor.name
226 386
227 >>> print ed.build.buildstate
228- Successful build
229+ Successfully built
230 >>> print ed.build.distroarchseries.processorfamily.name
231 x86
232 >>> print ed.build.distroarchseries.architecturetag
233
234=== modified file 'lib/lp/soyuz/stories/ppa/xx-copy-packages.txt'
235--- lib/lp/soyuz/stories/ppa/xx-copy-packages.txt 2010-03-27 03:11:00 +0000
236+++ lib/lp/soyuz/stories/ppa/xx-copy-packages.txt 2010-04-19 03:44:25 +0000
237@@ -299,7 +299,7 @@
238 James Blackwell
239 PPA for James Blackwell
240 i386 build of pmount 0.1-1
241- Build status Pending build
242+ Build status Needs building
243 Start (2505) What's this?
244 Build details
245 Source: pmount - 0.1-1
246
247=== modified file 'lib/lp/soyuz/stories/soyuz/xx-build-record.txt'
248--- lib/lp/soyuz/stories/soyuz/xx-build-record.txt 2010-04-09 15:46:09 +0000
249+++ lib/lp/soyuz/stories/soyuz/xx-build-record.txt 2010-04-19 03:44:25 +0000
250@@ -64,7 +64,7 @@
251 i386 build of testing 1.0 in ubuntutest breezy-autotest RELEASE
252 ...
253 Build status
254- Pending build
255+ Needs building
256 Start in ... (2505) What's this?
257 Build details
258 Source: testing - 1.0
259@@ -84,7 +84,7 @@
260 i386 build of testing 1.0 in ubuntutest breezy-autotest RELEASE
261 ...
262 Build status
263- Pending build
264+ Needs building
265 Build details
266 Source: testing - 1.0
267 Archive: Primary Archive for Ubuntu Test
268@@ -136,7 +136,7 @@
269
270 >>> print extract_text(find_tag_by_id(admin_browser.contents, 'status'))
271 Build status
272- Pending build
273+ Needs building
274 Start in ... (0) Rescore build What's this?
275
276 Eventually a pending build record will get started, and while it's
277@@ -205,7 +205,7 @@
278 >>> print extract_text(
279 ... find_tag_by_id(anon_browser.contents, 'status'))
280 Build status
281- Could not be uploaded correctly on Bob The Builder
282+ Failed to upload on Bob The Builder
283 Started ... ago
284 Finished ... (took 1 minute, 0.0 seconds)
285 buildlog (7 bytes)
286@@ -231,8 +231,7 @@
287 >>> print extract_text(
288 ... find_tag_by_id(admin_browser.contents, 'status'))
289 Build status
290- Could not be uploaded correctly
291- on Bob The Builder Retry this build
292+ Failed to upload on Bob The Builder Retry this build
293 Started ... ago
294 Finished ... (took 1 minute, 0.0 seconds)
295 buildlog (7 bytes)
296@@ -249,7 +248,7 @@
297 Retry i386 build of testing 1.0 in ubuntutest breezy-autotest RELEASE
298 ...
299 The status of i386 build of testing 1.0 in ubuntutest
300- breezy-autotest RELEASE is Could not be uploaded correctly.
301+ breezy-autotest RELEASE is Failed to upload.
302 Retrying this build will destroy its history and logs.
303 By default, this build will be retried only after other pending
304 builds; please contact a build daemon administrator if you need
305@@ -263,7 +262,7 @@
306 >>> print extract_text(
307 ... find_tag_by_id(admin_browser.contents, 'status'))
308 Build status
309- Could not be uploaded correctly on Bob The Builder Retry this build
310+ Failed to upload on Bob The Builder Retry this build
311 Started ... ago
312 Finished ... (took 1 minute, 0.0 seconds)
313 buildlog (7 bytes)
314@@ -281,7 +280,7 @@
315
316 >>> print extract_text(find_tag_by_id(admin_browser.contents, 'status'))
317 Build status
318- Pending build
319+ Needs building
320 Start in ... (0) Rescore build What's this?
321
322 >>> admin_browser.getLink("Retry this build").click()
323@@ -318,7 +317,7 @@
324 >>> print extract_text(
325 ... find_tag_by_id(anon_browser.contents, 'status'))
326 Build status
327- Successful build on Bob The Builder
328+ Successfully built on Bob The Builder
329 Started on 2008-01-01
330 Finished on 2008-01-01 (took 5 minutes, 0.0 seconds)
331 buildlog (6 bytes)
332@@ -455,7 +454,7 @@
333
334 >>> print extract_text(find_tag_by_id(anon_browser.contents, 'status'))
335 Build status
336- Successful build on Bob The Builder
337+ Successfully built on Bob The Builder
338 Started on ...
339 Finished on ... (took 5 minutes, 0.0 seconds)
340 buildlog (6 bytes)
341
342=== modified file 'lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt'
343--- lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt 2010-03-27 02:47:07 +0000
344+++ lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt 2010-04-19 03:44:25 +0000
345@@ -136,17 +136,17 @@
346
347 >>> print_build_rows(anon_browser.contents)
348 ------------------------------
349- Successful build
350+ Successfully built
351 hppa build of mozilla-firefox 0.9 in ubuntu warty RELEASE
352 Build started on 2007-08-10 on Bob The Builder and finished on 2007-08-10
353 taking 15 seconds &mdash; see the log
354 ------------------------------
355- Successful build
356+ Successfully built
357 i386 build of commercialpackage 1.0-1 in ubuntu breezy-autotest RELEASE
358 Build started at an unknown time on an unknown build machine and finished
359 on 2007-08-09 taking
360 ------------------------------
361- Could not be uploaded correctly
362+ Failed to upload
363 i386 build of cdrkit 1.0 in ubuntu breezy-autotest RELEASE
364 Build started on 2007-04-19 on Bob The Builder and finished on 2007-04-20
365 taking a minute &mdash; see the log
366@@ -164,23 +164,23 @@
367 >>> anon_browser.getLink("Next").click()
368 >>> print_build_rows(anon_browser.contents)
369 ------------------------------
370- Could not build because source package was superseded
371+ Build for superseded Source
372 i386 build of at 0.00 in ubuntu warty RELEASE
373 ------------------------------
374- Could not build because source package was superseded
375+ Build for superseded Source
376 i386 build of linux-source-2.6.15 2.6.15.3 in ubuntu warty RELEASE
377 ------------------------------
378- Could not build because source package was superseded
379+ Build for superseded Source
380 i386 build of netapplet 0.99.6-1 in ubuntu warty RELEASE
381 ------------------------------
382- Could not build because of missing dependencies
383+ Dependency wait
384 i386 build of libstdc++ b8p in ubuntu hoary RELEASE
385 Missing dependencies:
386 cpp (&gt;= 4:4.0.1-3), gcc-4.0 (&gt;= 4.0.1-2)
387 Build started on 2006-02-27 on Bob The Builder and finished on 2006-02-28
388 taking six minutes &mdash; see the log
389 ------------------------------
390- Pending build
391+ Needs building
392 i386 build of alsa-utils 1.0.9a-4ubuntu1 in ubuntu hoary RELEASE
393 Pending (10)
394 ------------------------------
395@@ -193,27 +193,27 @@
396 >>> anon_browser.getControl("Filter").click()
397 >>> print_build_rows(anon_browser.contents)
398 ------------------------------
399- Successful build
400+ Successfully built
401 hppa build of mozilla-firefox 0.9 in ubuntu warty RELEASE
402 Build started on 2007-08-10 on Bob The Builder and finished on 2007-08-10
403 taking 15 seconds &mdash; see the log
404 ------------------------------
405- Successful build
406+ Successfully built
407 i386 build of commercialpackage 1.0-1 in ubuntu breezy-autotest RELEASE
408 Build started at an unknown time on an unknown build machine and finished
409 on 2007-08-09 taking
410 ------------------------------
411- Successful build
412+ Successfully built
413 i386 build of pmount 0.1-1 in ubuntu hoary RELEASE
414 Build started on 2005-03-24 on Bob The Builder and finished on 2005-03-25
415 taking a minute &mdash; see the log
416 ------------------------------
417- Successful build
418+ Successfully built
419 hppa build of pmount 0.1-1 in ubuntu hoary RELEASE
420 Build started on 2005-03-24 on Bob The Builder and finished on 2005-03-25
421 taking a minute &mdash; see the log
422 ------------------------------
423- Successful build
424+ Successfully built
425 i386 build of pmount 0.1-1 in ubuntu breezy-autotest RELEASE
426 Build started on 2005-03-24 on Bob The Builder and finished on 2005-03-25
427 taking a minute &mdash; see the log
428@@ -223,7 +223,7 @@
429 >>> anon_browser.getControl("Filter").click()
430 >>> print_build_rows(anon_browser.contents)
431 ------------------------------
432- Could not build because of missing dependencies
433+ Dependency wait
434 i386 build of libstdc++ b8p in ubuntu hoary RELEASE
435 Missing dependencies:
436 cpp (&gt;= 4:4.0.1-3), gcc-4.0 (&gt;= 4.0.1-2)
437@@ -301,17 +301,17 @@
438
439 >>> print_build_rows(anon_browser.contents)
440 ------------------------------
441- Successful build
442- hppa build of mozilla-firefox 0.9 in ubuntu warty RELEASE
443- Build started on 2007-08-10 and finished on 2007-08-10
444- taking 15 seconds &mdash; see the log
445- ------------------------------
446- Successful build
447- hppa build of mozilla-firefox 0.9 in ubuntu warty RELEASE
448- Build started on 2007-08-10 and finished on 2007-08-10
449- taking 15 seconds &mdash; see the log
450- ------------------------------
451- Successful build
452+ Successfully built
453+ hppa build of mozilla-firefox 0.9 in ubuntu warty RELEASE
454+ Build started on 2007-08-10 and finished on 2007-08-10
455+ taking 15 seconds &mdash; see the log
456+ ------------------------------
457+ Successfully built
458+ hppa build of mozilla-firefox 0.9 in ubuntu warty RELEASE
459+ Build started on 2007-08-10 and finished on 2007-08-10
460+ taking 15 seconds &mdash; see the log
461+ ------------------------------
462+ Successfully built
463 i386 build of pmount 0.1-1 in ubuntu warty RELEASE
464 Build started on 2007-07-23 and finished on 2007-07-24
465 taking a minute &mdash; see the log
466@@ -334,7 +334,7 @@
467 >>> anon_browser.getLink("Next").click()
468 >>> print_build_rows(anon_browser.contents)
469 ------------------------------
470- Could not be uploaded correctly
471+ Failed to upload
472 i386 build of cdrkit 1.0 in ubuntu breezy-autotest RELEASE
473 Build started on 2007-04-19 and finished on 2007-04-20
474 taking a minute &mdash; see the log
475@@ -344,13 +344,13 @@
476 Build started on 2006-12-01 and finished on 2006-12-01
477 taking 1 second &mdash; see the log
478 ------------------------------
479- Could not build because source package was superseded
480+ Build for superseded Source
481 i386 build of netapplet 0.99.6-1 in ubuntu warty RELEASE
482 ------------------------------
483- Could not build because source package was superseded
484+ Build for superseded Source
485 i386 build of linux-source-2.6.15 2.6.15.3 in ubuntu warty RELEASE
486 ------------------------------
487- Could not build because source package was superseded
488+ Build for superseded Source
489 i386 build of at 0.00 in ubuntu warty RELEASE
490 ------------------------------
491
492@@ -360,7 +360,7 @@
493 >>> anon_browser.getLink("Next").click()
494 >>> print_build_rows(anon_browser.contents)
495 ------------------------------
496- Could not build because of missing dependencies
497+ Dependency wait
498 i386 build of libstdc++ b8p in ubuntu hoary RELEASE
499 Missing dependencies:
500 cpp (&gt;= 4:4.0.1-3), gcc-4.0 (&gt;= 4.0.1-2)
501
502=== modified file 'lib/lp/soyuz/stories/soyuz/xx-private-builds.txt'
503--- lib/lp/soyuz/stories/soyuz/xx-private-builds.txt 2010-03-27 02:47:07 +0000
504+++ lib/lp/soyuz/stories/soyuz/xx-private-builds.txt 2010-04-19 03:44:25 +0000
505@@ -338,7 +338,7 @@
506 >>> portlet = find_portlet(browser.contents, 'Builds')
507 >>> print extract_text(portlet)
508 Builds
509- breezy-autotest i386 Successful build
510+ breezy-autotest i386 Successfully built
511
512 >>> print browser.getLink('i386').url
513 http://launchpad.dev/~cprov/+archive/p3a/+build/...