Merge lp:~abentley/launchpad/skip-repeat-builds into lp:launchpad/db-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Brad Crittenden | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 9481 | ||||
Proposed branch: | lp:~abentley/launchpad/skip-repeat-builds | ||||
Merge into: | lp:launchpad/db-devel | ||||
Diff against target: |
362 lines (+176/-24) 8 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+14/-7) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+24/-3) lib/lp/code/errors.py (+27/-6) lib/lp/code/interfaces/webservice.py (+4/-3) lib/lp/code/model/sourcepackagerecipe.py (+9/-1) lib/lp/code/model/sourcepackagerecipebuild.py (+3/-0) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+76/-2) lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+19/-2) |
||||
To merge this branch: | bzr merge lp:~abentley/launchpad/skip-repeat-builds | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+27954@code.launchpad.net |
Commit message
Avoid creating duplicate pending builds.
Description of the change
= Summary =
Fix bug #595686: duplicate pending builds can be created.
== Proposed fix ==
Raise BuildAlreadyPending SourcePackageRe
arguments match a build already pending. Handle this in the UI as a validation
error. Handle this SourcePackageRe
next distroseries.
== Pre-implementation notes ==
Preimplementation was with thumper
== Implementation details ==
Also added tests for TooManyBuilds on the webservice. Some quota tests had to
be updated so that they did not raise BuildAlreadyPending instead of
TooManyBuilds.
== Tests ==
bin/test -t test_request_
== Demo and Q/A ==
Create a build. Attempt to create a duplicate build. You should get an error
that the build is already pending.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
== Pyflakes notices ==
lib/lp/
8: 'TooManyBuilds' imported but unused
8: 'CodeImportAlre
8: 'CodeImportNotI
8: 'BuildAlreadyPe
8: 'BranchMergePro
11: 'IBranchSet' imported but unused
11: 'BranchCreatorN
11: 'IBranch' imported but unused
11: 'BranchExists' imported but unused
11: 'BranchCreatorN
14: 'IBranchMergePr
15: 'IBranchSubscri
16: 'ICodeImport' imported but unused
17: 'ICodeReviewCom
18: 'ICodeReviewVot
19: 'IStaticDiff' imported but unused
19: 'IDiff' imported but unused
19: 'IPreviewDiff' imported but unused
20: 'ISourcePackage
21: 'ISourcePackage
== Pylint notices ==
lib/lp/
19: [W0611] Unused import IDiff
8: [W0611] Unused import TooManyBuilds
15: [W0611] Unused import IBranchSubscription
11: [W0611] Unused import BranchCreatorNo
8: [W0611] Unused import CodeImportNotIn
14: [W0611] Unused import IBranchMergePro
8: [W0611] Unused import CodeImportAlrea
11: [W0611] Unused import BranchCreatorNo
16: [W0611] Unused import ICodeImport
20: [W0611] Unused import ISourcePackageR
18: [W0611] Unused import ICodeReviewVote
11: [W0611] Unused import IBranchSet
19: [W0611] Unused import IStaticDiff
8: [W0611] Unused import BuildAlreadyPending
11: [W0611] Unused import IBranch
19: [W0611] Unused import IPreviewDiff
8: [W0611] Unused import BranchMergeProp
11: [W0611] Unused import BranchExists
21: [W0611] Unused import ISourcePackageR
17: [W0611] Unused import ICodeReviewComment
Hi Aaron,
Please add a docstring for test_requestBui ldRejectRepeats .
The docstring for test_requestBui ldRejectOverQuo ta is identical to the previous. c-n-p error?
Otherwise this branch looks really straightforward. Thanks.