Merge lp:~adeuring/launchpad/bug-446600 into lp:launchpad
Proposed by
Abel Deuring
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~adeuring/launchpad/bug-446600 |
Merge into: | lp:launchpad |
Diff against target: |
25 lines 2 files modified
lib/canonical/launchpad/browser/hwdb.py (+1/-1) lib/canonical/launchpad/pagetests/hwdb/01-submit-data.txt (+2/-0) |
To merge this branch: | bzr merge lp:~adeuring/launchpad/bug-446600 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer (community) | Approve | ||
Review via email: mp+13430@code.launchpad.net |
To post a comment you must log in.
This branch fixes bug 446600: "HWSubmissionMi ssingFields exceptions should be updated to be informational only"
The fix is quite simple: Diogo added in r9660 a method handling() to our ErrorReportingU tility, which allow to label logged OOPSes as being informational. So I changed the call error_utility. raising( ) to error_utlitiy. handling( )
Test: ./bin/test -f canonical pagetests.hwdb
Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: /launchpad/ browser/ hwdb.py /launchpad/ pagetests/ hwdb/01- submit- data.txt
lib/canonical
lib/canonical