Notify OSD

Merge lp:~agateau/notify-osd/bump-spec-version into lp:notify-osd/trunk

  1. bump-spec-version
  2. Merge into main
Proposed by Aurélien Gâteau
Status: Merged
Approved by: Mirco Müller
Approved revision: 389
Merged at revision: not available
Proposed branch: lp:~agateau/notify-osd/bump-spec-version
Merge into: lp:notify-osd/trunk
Diff against target: None lines
To merge this branch: bzr merge lp:~agateau/notify-osd/bump-spec-version
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+11369@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Aurélien Gâteau (agateau) wrote :

Just a bump of the spec version number because 1.0 was actually already out by the time notify-osd was created.

Revision history for this message
Mirco Müller (macslow) wrote :

> Just a bump of the spec version number because 1.0 was actually already out by
> the time notify-osd was created.

Ah ok. Can go in. I'll do that today.

review: Approve
Revision history for this message
Mirco Müller (macslow) wrote :

> Just a bump of the spec version number because 1.0 was actually already out by
> the time notify-osd was created.

But feel rebuked by me, as you did not run the test-suite after you change. Doing that would have pointed you towards notify-osd/tests/test-withlib.c (./test-modules -p /libnotify) failing for /libnotify/test_withlib_get_server_information

lp:~agateau/notify-osd/bump-spec-version updated
390. By Aurélien Gâteau

Bumped spec versions in tests as well

Revision history for this message
Aurélien Gâteau (agateau) wrote :

> > Just a bump of the spec version number because 1.0 was actually already out
> by
> > the time notify-osd was created.
>
> But feel rebuked by me, as you did not run the test-suite after you change.
> Doing that would have pointed you towards notify-osd/tests/test-withlib.c
> (./test-modules -p /libnotify) failing for
> /libnotify/test_withlib_get_server_information

Sorry about that. Just fixed this in r390.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/stack.c'
2--- src/stack.c 2009-08-26 11:17:55 +0000
3+++ src/stack.c 2009-09-08 14:59:49 +0000
4@@ -825,7 +825,7 @@
5 *out_name = g_strdup ("notify-osd");
6 *out_vendor = g_strdup ("Canonical Ltd");
7 *out_version = g_strdup ("1.0");
8- *out_spec_ver = g_strdup ("0.10");
9+ *out_spec_ver = g_strdup ("1.1");
10
11 return TRUE;
12 }

Subscribers

People subscribed via source and target branches