qtubuntu-media

Merge lp:~ahayzen/qtubuntu-media/fix-1510225-isReadOnly-not-respecting-canEditTracks into lp:qtubuntu-media

  1. fix-1510225-isReadOnly-not-respecting-canEditTracks
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Jim Hodapp
Approved revision: 110
Merged at revision: 115
Proposed branch: lp:~ahayzen/qtubuntu-media/fix-1510225-isReadOnly-not-respecting-canEditTracks
Merge into: lp:qtubuntu-media
Diff against target: 12 lines (+1/-1)
1 file modified
src/aal/aalmediaplaylistprovider.cpp (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/qtubuntu-media/fix-1510225-isReadOnly-not-respecting-canEditTracks
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+306849@code.launchpad.net

Commit message

* Fix isReadOnly to respect can_edit_tracks correctly, so when can_edit_tracks is True isReadOnly is False

Description of the change

* Fix isReadOnly to respect can_edit_tracks correctly, so when can_edit_tracks is True isReadOnly is False

This should be tested using the silo 1972 [0] and the music-app which enables load/save support [1] (you should notice a m3u file here /home/phablet/.local/share/com.ubuntu.music/queue.m3u).

0 - https://requests.ci-train.ubuntu.com/#/ticket/1972
1 - https://code.launchpad.net/~ahayzen/music-app/fix-1510225-use-save-load-playlist

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/aal/aalmediaplaylistprovider.cpp'
2--- src/aal/aalmediaplaylistprovider.cpp 2016-07-20 21:26:54 +0000
3+++ src/aal/aalmediaplaylistprovider.cpp 2016-09-27 09:51:58 +0000
4@@ -89,7 +89,7 @@
5 }
6
7 try {
8- return m_hubTrackList->can_edit_tracks();
9+ return !m_hubTrackList->can_edit_tracks();
10 }
11 catch (const std::runtime_error &e) {
12 qWarning() << "Failed to see if tracklist is editable: " << e.what();

Subscribers

People subscribed via source and target branches