lp:~ahayzen/ubuntu-settings-components/fix-compiler-warnings

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~phablet-team/ubuntu-settings-components/printer-components at revision 228

Ubuntu Phablet Team: Pending requested 2017-02-06

Diff: 697 lines (+164/-52)

9 files modified

plugins/Ubuntu/Settings/Printers/backend/backend.cpp (+54/-1)
plugins/Ubuntu/Settings/Printers/backend/backend_cups.cpp (+36/-18)
plugins/Ubuntu/Settings/Printers/backend/backend_pdf.cpp (+1/-1)
plugins/Ubuntu/Settings/Printers/cups/cupspkhelper.cpp (+2/-0)
plugins/Ubuntu/Settings/Printers/printer/printer.cpp (+26/-12)
plugins/Ubuntu/Settings/Printers/printer/printerjob.cpp (+1/-1)
plugins/Ubuntu/Settings/Printers/printers/printers.cpp (+17/-4)
plugins/Ubuntu/Settings/Printers/utils.h (+9/-6)
tests/unittests/Printers/mockbackend.h (+18/-9)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

228. By Andrew Hayzen on 2017-02-06

* Resolve console warnings - add TODOs in methods that should be implemented where I've put a fake return value for now
* Set a default for switches that compiler thinks it can reach the end of the control without
* Add return values for methods that are not implemented yet
* Add Q_UNUSED for parameters that aren't used

227. By Andrew Hayzen on 2017-02-06

* Link notifications to JobModel - removing polling
* Fix compiler errors that appeared from the previous branch
* Fix logic change in last branch that was wrong way around

226. By Andrew Hayzen on 2017-02-03

* Add updateFrom to Printer and PrinterJob
* Call updateFrom in PrinterModel and JobModel when printers are the same
* Emit dataChanged signal in models when updateFrom returns a change
* Add deepCompare to Printer and PrinterJob

225. By Jonas G. Drange on 2017-02-03

* Deprecate QTimer based update()
* Replace with cups subscription based update()
* Fixes tests.

224. By Andrew Hayzen on 2017-02-02

* Add JobModel which lists the jobs for a certain printer
* Add JobRole to PrinterModel to access jobs
* Add JobState enum to track enums from cups
* Add example Queue which lists jobs for a printer with their name, id, status and allows you to cancel the job by clicking

223. By Andrew Hayzen on 2017-02-02

* Add cancel method to Printers

222. By Andrew Hayzen on 2017-01-31

* Always fit-to-page for now as printing app doesn't know about page sizes or scaling yet

221. By Jonas G. Drange on 2017-01-31

  * allows creation of printers in example qml, and by extension the API
  * create printers by either providing a PPD file, or select a PPD from the database
  * adds a DriverModel that holds printer drivers, which can be filtered
  * adds testing of DriverModel

220. By Andrew Hayzen on 2017-01-31

* Skip null printers for now as they result in errors due to missing ppd definitions and segfaults when trying to print

219. By Jonas G. Drange on 2017-01-27

resolves conflicts