NetworkManager

Merge ~alfonsosanchezbeato/network-manager:add-changelog into network-manager:snap-1.10

  1. Git
  2. lp:~alfonsosanchezbeato/network-manager
  3. add-changelog
  4. Merge into snap-1.10
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: e871b2f9ab2100d57bcd84f6669401bd4614d8a8
Merged at revision: 46666ae1af9f07de40305e9936aac21833ed37f4
Proposed branch: ~alfonsosanchezbeato/network-manager:add-changelog
Merge into: network-manager:snap-1.10
Diff against target: 18 lines (+7/-0)
1 file modified
snap/snapcraft.yaml (+7/-0)
Reviewer Review Type Date Requested Status
Tony Espy Approve
System Enablement Bot continuous-integration Approve
Konrad Zapałowicz (community) code Approve
Review via email: mp+372526@code.launchpad.net

Commit message

snap: copy changelog to package

Description of the change

snap: copy changelog to package

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) :
review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:e871b2f9ab2100d57bcd84f6669401bd4614d8a8
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/426/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/458
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/458
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/458
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/458
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1251
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/993
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1040/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/426/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index b43ac42..f145d5e 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -61,6 +61,13 @@ parts:
6 plugin: dump
7 source: snap-common
8
9+ changelog:
10+ plugin: nil
11+ override-build: |
12+ cp "$SNAPCRAFT_PROJECT_DIR"/ChangeLog-snap.txt "$SNAPCRAFT_PART_INSTALL"/ChangeLog
13+ organize:
14+ ChangeLog: usr/share/doc/network-manager/ChangeLog
15+
16 dnsmasq:
17 plugin: make
18 source: https://git.launchpad.net/ubuntu/+source/dnsmasq

Subscribers

People subscribed via source and target branches