Launchpad itself

Merge lp:~allenap/launchpad/remove-striped_class into lp:launchpad

  1. remove-striped_class
  2. Merge into devel
Proposed by Gavin Panella
Status: Merged
Approved by: Edwin Grubbs
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~allenap/launchpad/remove-striped_class
Merge into: lp:launchpad
Diff against target: 40 lines (+0/-16)
1 file modified
lib/canonical/launchpad/webapp/publisher.py (+0/-16)
To merge this branch: bzr merge lp:~allenap/launchpad/remove-striped_class
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) code Approve
Review via email: mp+14996@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

I noticed that LaunchpadView.striped_class is not used anywhere, and looks odd where it is.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Looks good.

-Edwin

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/webapp/publisher.py'
2--- lib/canonical/launchpad/webapp/publisher.py 2009-11-14 22:44:07 +0000
3+++ lib/canonical/launchpad/webapp/publisher.py 2009-11-27 09:41:11 +0000
4@@ -38,8 +38,6 @@
5 from zope.security.checker import ProxyFactory, NamesChecker
6 from zope.traversing.browser.interfaces import IAbsoluteURL
7
8-from canonical.cachedproperty import cachedproperty
9-from canonical.config import config
10 from canonical.launchpad.layers import setFirstLayer, WebServiceLayer
11 from canonical.launchpad.webapp.vhosts import allvhosts
12 from canonical.launchpad.webapp.interfaces import (
13@@ -232,7 +230,6 @@
14 many templates not set via zcml, or you want to do
15 rendering from Python.
16 - isBetaUser <-- whether the logged-in user is a beta tester
17- - striped_class<-- a tr class for an alternating row background
18 """
19
20 def __init__(self, context, request):
21@@ -285,19 +282,6 @@
22 else:
23 return self.render()
24
25- @cachedproperty
26- def striped_class(self):
27- """Return a generator which yields alternating CSS classes.
28-
29- This is to be used for HTML tables in which the row colors should be
30- alternated.
31- """
32- def bg_stripe_generator():
33- while True:
34- yield 'white'
35- yield 'shaded'
36- return bg_stripe_generator()
37-
38 def _getErrorMessage(self):
39 """Property getter for `error_message`."""
40 return self._error_message