Launchpad itself

~andrey-fedoseev/launchpad:bug-attachment-url

Git
lp:~andrey-fedoseev/launchpad
bug-attachment-url

Last commit made on 2022-10-21

Get this branch:: git clone -b bug-attachment-url https://git.launchpad.net/~andrey-fedoseev/launchpad

Only Andrey Fedoseev can upload to this branch. If you are Andrey Fedoseev please log in for upload directions.

Branch merges

Merged into launchpad:master

Colin Watson (community): Approve on 2022-10-20

Branch information

Name:: bug-attachment-url

Repository:: lp:~andrey-fedoseev/launchpad

Recent commits

e33a250... by Andrey Fedoseev on 2022-10-21

Address peer review comments

- `BugAttachmentEditView` exclude `contenttype` field from the form when there's no file attached rather than specifying the list of fields to be included
- Add tests for exporting bugs that have attachments with URLs
- Transform `BugAttachment.title` to a property. Make `BugAttachment._title` optional in ORM (it's already nullable in the schema)
- Fix tests in `patches-view.rst`

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

eac6256... by Andrey Fedoseev on 2022-10-11

Improve the `BugAttachment` links:

- Use the formatter API to create the links
- Use different icons depending on the link type: external URL, a patch, a downloadable file
- Add rel=nofollow to external URLs

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

0c30702... by Andrey Fedoseev on 2022-10-04

Add `url` to `BugAttachment`

`libraryfile` field of `BugAttachment` is not optional, an attachment can either contain a file, or have a URL

Add `displayed_url` property to `BugAttachment` that contains either a proxied attachment file URL, or the URL associated with the attachment.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

af14360... by Andrey Fedoseev on 2022-09-28

Replace `Cve.discoverer` with `discovered_by`

Merged from https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/430020

0dc9a35... by Andrey Fedoseev on 2022-09-16

UCT import/export: handle the `cve.discovered_by` field

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

e131d70... by Andrey Fedoseev on 2022-09-16

Replace `Cve.discoverer` with `discovered_by`

`Cve.discoverer` is a reference to a `Person`, but it doesn't really work with the real data in Ubuntu CVE Tracker.

In UCT, `Discovered-By` is a free-form field which usually contains name of one or more people or an organization name which is impossible to map to a `Person`.

We agreed that a plain text field would work better for this case.

e1bf448... by Andrey Fedoseev on 2022-09-28