~andrey-fedoseev/launchpad:snap-store-auth-error

Branch merges

Propose for merging

Merged into launchpad:master

Colin Watson (community): Approve on 2022-11-29

Diff: 154 lines (+56/-11)

5 files modified

lib/lp/snappy/browser/snap.py (+26/-10)
lib/lp/snappy/browser/tests/test_snap.py (+20/-0)
lib/lp/snappy/interfaces/snapstoreclient.py (+5/-0)
lib/lp/snappy/model/snapstoreclient.py (+3/-0)
lib/lp/snappy/tests/test_snapstoreclient.py (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

064c8df... by Andrey Fedoseev on 2022-11-29

Display info message when user tries to authorize store upload for snap that isn't registered

Previously, that would cause an Internal Server Error

LP: #1997565

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

2dc8174... by Colin Watson on 2022-11-27

Connect stdin/stdout of site search test service to /dev/null

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/433673

705b87c... by Colin Watson on 2022-11-27

Return proxied object from makePreviewDiff

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/433675

008ba08... by Colin Watson on 2022-11-26

Plug several simple open() resource leaks

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/433678

ce265ad... by Colin Watson on 2022-11-25

Plug several simple open() resource leaks

Brought to you by some initial experiments with
https://pypi.org/project/pyastgrep/:

  pyastgrep './/Call/func/Attribute[@attr="read" or @attr="write"]/value/Call/func/Name[@id="open"]'

e28ecdd... by Colin Watson on 2022-11-25

Return proxied object from makePreviewDiff

`LaunchpadObjectFactory` issues `UnproxiedFactoryMethodWarning` when its
methods return objects not wrapped in a security proxy, since that tends
to result in tests that are less accurate simulations of production.

c85cf87... by Colin Watson on 2022-11-25

Connect stdin/stdout of site search test service to /dev/null

Setting these up as pipes without having anything ever communicate with
it, as we previously did, had two disadvantages: it could cause the test
service to block if it tries to write too much to stdout, and it caused
a `ResourceWarning` due to `proc.stdout` never being explicitly closed.

9fdf1d1... by Colin Watson on 2022-11-25

Fix test failure in xx-builders.rst

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/433670

e738805... by Colin Watson on 2022-11-25

Fix test failure in xx-builders.rst

cd0dc34... by Colin Watson on 2022-11-25

Allow partitioning build farm by resources

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/433380