Ubuntu
fuse-umfuse-ext2 package

Merge lp:~andy-m-caldwell/ubuntu/trusty/fuse-umfuse-ext2/fix-for-1674868 into lp:ubuntu/trusty/fuse-umfuse-ext2

  1. Trusty (14.04)
  2. fix-for-1674868
  3. Merge into trusty
Proposed by Andy Caldwell
Status: Needs review
Proposed branch: lp:~andy-m-caldwell/ubuntu/trusty/fuse-umfuse-ext2/fix-for-1674868
Merge into: lp:ubuntu/trusty/fuse-umfuse-ext2
Diff against target: 31 lines (+8/-2)
2 files modified
debian/changelog (+6/-0)
fuse-ext2/op_link.c (+2/-2)
To merge this branch: bzr merge lp:~andy-m-caldwell/ubuntu/trusty/fuse-umfuse-ext2/fix-for-1674868
Reviewer Review Type Date Requested Status
Simon Quigley Needs Resubmitting
Ubuntu branches Pending
Review via email: mp+320722@code.launchpad.net

Description of the change

Correctly release locks in op_link (LP: #1674868)

To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hello Andy, I apologize for the delay in getting this reviewed.

Ubuntu no longer uses Bazaar for our packaging, and it would be preferred if you were to attach a debdiff (i.e. a diff similar to below) to the bug report. Once that's done, please subscribe ~ubuntu-sponsors to the bug report and someone will promptly look at it.

Here's a couple of packaging changes that I suggest you address when you do that:
 1. Please convert your change to a patch under debian/patches and add a DEP-3 header. More information is available here: https://raphaelhertzog.com/2012/08/08/how-to-use-quilt-to-manage-patches-in-debian-packages/
 2. Since this will need to be a Stable Release Update (SRU), please make sure to modify the bug report to reflect the SRU policy: https://wiki.ubuntu.com/StableReleaseUpdates
If it is a low priority change like you suggest in the changelog, we would like a justification for why you believe it is needed in Trusty.

Again, I apologize for the delay, and thank you for your contribution to Ubuntu and willingness to get this bug fix! I look forward to sponsoring your patch over on the bug report. :)

review: Needs Resubmitting
Reply

Unmerged revisions

8. By Andy Caldwell

Correctly release locks in op_link (LP: #1674868)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-05-12 15:48:18 +0000
3+++ debian/changelog 2017-03-22 20:02:56 +0000
4@@ -1,3 +1,9 @@
5+fuse-umfuse-ext2 (0.4-1.1ubuntu1) trusty; urgency=low
6+
7+ * Correctly release locks in op_link (LP: #1674868)
8+
9+ -- Andrew Caldwell <andy.m.caldwell@googlemail.com> Wed, 22 Mar 2017 19:42:35 +0000
10+
11 fuse-umfuse-ext2 (0.4-1.1) unstable; urgency=low
12
13 * Non-maintainer upload.
14
15=== modified file 'fuse-ext2/op_link.c'
16--- fuse-ext2/op_link.c 2012-06-24 20:58:20 +0000
17+++ fuse-ext2/op_link.c 2017-03-22 20:02:56 +0000
18@@ -101,11 +101,11 @@
19 }
20 free_split(p_path, r_path);
21 debugf("done");
22- FUSE_EXT2_LOCK;
23+ FUSE_EXT2_UNLOCK;
24 return 0;
25 err_free_split:
26 free_split(p_path, r_path);
27 err:
28- FUSE_EXT2_LOCK;
29+ FUSE_EXT2_UNLOCK;
30 return rc;
31 }

Subscribers

People subscribed via source and target branches

to all changes: