Gwibber

Merge lp:~asac/gwibber/trunk.notify.action-capabilities into lp:gwibber/1.2

  1. trunk.notify.action-capabilities
  2. Merge into gwibber-1.2
Proposed by Alexander Sack
Status: Merged
Merged at revision: not available
Proposed branch: lp:~asac/gwibber/trunk.notify.action-capabilities
Merge into: lp:gwibber/1.2
To merge this branch: bzr merge lp:~asac/gwibber/trunk.notify.action-capabilities
Reviewer Review Type Date Requested Status
Dominic Evans (community) Approve
Review via email: mp+3652@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexander Sack (asac) wrote :

make use of notification actions sensitive on whether the notification daemon supports actions or not.

Revision history for this message
Dominic Evans (oldmanuk) wrote :

perhaps it would be preferable to query the capabilities of the notification deamon on initialisation rather than on every call to notify(..) ?

Revision history for this message
Alexander Sack (asac) wrote :

On Mon, Feb 16, 2009 at 03:08:35PM -0000, Dominic Evans wrote:
> perhaps it would be preferable to query the capabilities of the notification deamon on initialisation rather than on every call to notify(..) ?

yes, but to do it right we also would need to listen for name changes
and so on. I think we should do it properly together with the TODOs in
that gintegration.py on trunk after 1.0. If you say that this is
essential i can do that. would just be a bugfix after 1.0.

 - Alexander

Revision history for this message
Dominic Evans (oldmanuk) wrote :

OK. I am happy to approve this merge to keep us compliant with Jaunty's notification changes in the immediate future.

review: Approve
Revision history for this message
Alexander Sack (asac) wrote :

On Mon, Feb 16, 2009 at 04:48:01PM -0000, Dominic Evans wrote:
> Review: Approve
> OK. I am happy to approve this merge to keep us compliant with Jaunty's notification changes in the immediate future.

Dont forget the 1.0 branch merge, so we can get that into jaunty by
tomorrow ;). Thanks!

 - Alexander

Subscribers

People subscribed via source and target branches