update notifier

Merge lp:~azzar1/update-notifier/fix-zombie-1809505 into lp:update-notifier/ubuntu

  1. fix-zombie-1809505
  2. Merge into ubuntu
Proposed by Andrea Azzarone
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 949
Merged at revision: 949
Proposed branch: lp:~azzar1/update-notifier/fix-zombie-1809505
Merge into: lp:update-notifier/ubuntu
Diff against target: 45 lines (+10/-3)
2 files modified
debian/changelog (+7/-0)
src/update-notifier.c (+3/-3)
To merge this branch: bzr merge lp:~azzar1/update-notifier/fix-zombie-1809505
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+361441@code.launchpad.net

Commit message

Don't use G_SPAWN_DO_NOT_REAP_CHILD in order to avoid zombie processes.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

looks good, thx

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2018-11-13 20:53:56 +0000
3+++ debian/changelog 2019-01-07 14:27:20 +0000
4@@ -1,3 +1,10 @@
5+update-notifier (3.192.11) UNRELEASED; urgency=medium
6+
7+ * src/update-notifier.c: Don't use G_SPAWN_DO_NOT_REAP_CHILD in order
8+ to avoid zombie processes. (LP: #1809505)
9+
10+ -- Andrea Azzarone <andrea.azzarone@canonical.com> Mon, 07 Jan 2019 12:49:07 +0000
11+
12 update-notifier (3.192.10) disco; urgency=medium
13
14 [ Andrea Azzarone ]
15
16=== modified file 'src/update-notifier.c'
17--- src/update-notifier.c 2018-11-07 14:59:18 +0000
18+++ src/update-notifier.c 2019-01-07 14:27:20 +0000
19@@ -188,7 +188,7 @@
20 argv[0] = "/usr/bin/pkexec";
21 argv[1] = (gchar*)cmd;
22 argv[2] = NULL;
23- g_spawn_async (NULL, argv, NULL, G_SPAWN_DO_NOT_REAP_CHILD, NULL, NULL, NULL, NULL);
24+ g_spawn_async (NULL, argv, NULL, G_SPAWN_DEFAULT, NULL, NULL, NULL, NULL);
25 }
26
27 void
28@@ -198,7 +198,7 @@
29 gchar *argv[2];
30 argv[0] = "/usr/lib/update-notifier/local-avahi-notification";
31 argv[1] = NULL;
32- g_spawn_async (NULL, argv, NULL, G_SPAWN_DO_NOT_REAP_CHILD, NULL, NULL, NULL, NULL);
33+ g_spawn_async (NULL, argv, NULL, G_SPAWN_DEFAULT, NULL, NULL, NULL, NULL);
34 }
35
36 void livepatch_check()
37@@ -207,7 +207,7 @@
38 gchar *argv[2];
39 argv[0] = "/usr/lib/update-notifier/livepatch-notification";
40 argv[1] = NULL;
41- g_spawn_async (NULL, argv, NULL, G_SPAWN_DO_NOT_REAP_CHILD, NULL, NULL, NULL, NULL);
42+ g_spawn_async (NULL, argv, NULL, G_SPAWN_DEFAULT, NULL, NULL, NULL, NULL);
43 }
44
45 static gboolean

Subscribers

People subscribed via source and target branches

to all changes: