Merge lp:~bac/launchpad/bug-421986-team-list-pages into lp:launchpad

= Summary =

Bug 421986 list three team pages that need mechanical updates for UI 3.0.

== Proposed fix ==

Provide changes to fulfill the new UI requirements.

== Pre-implementation notes ==

N/A

== Implementation details ==

* team-mailinglist-subscribers.pt
  * Convert to use main_only layout.
  * Move page title into the TeamMailingListSubscribersView as 'label'.
  * Leave the hand-crafted table construction in the view since it
    uses a four column presentation. I could create a
    four-column-list in the CSS if that is desired. The current
    approach works so I prefer to keep these changes minimal.

* team-mailinglist-moderate.pt
  * Convert to use main_only layout.
  * Remove page title from pagetitles.py. In
    TeamMailingListModerationView keep the existing 'label'.

* teammembership-invitation.pt
  * Convert to use main_only layout.
  * Move the pagetitle from pagetitles.py as 'label' and make
    page_title be a synonym for it. I *thought* having page_title was
    not going to be required after Barry's changes but it is for this
    view.

== Tests ==

bin/test -vvm lp.registry -t stories/mailinglists/subscriptions.txt \
     -t stories/mailinglists/moderation.txt

== Demo and Q/A ==

Screenshots are available at
http://people.canonical.com/~bac/bug-421986-team-list-pages/

* As Mark, go to https://launchpad.dev/~hwdb-team/+addmember and add
'testing-spanish-team'
  Then go to:
  https://launchpad.dev/~testing-spanish-team/+invitation/hwdb-team

* Go to https://launchpad.dev/~testing-spanish-team/+mailing-list-subscribers
  Note I for the screenshot I created a large team with lots of
  subscribers *and* hacked the dev config to use a batching size of 50
  (same as in production) rather than the normal 5 in the development
  environment. (If you'd like my script for creating the team with
  mailing list subscribers using launchpadlib let me know.)

  Also note I am unhappy that the default batch size is 50 but we're
  using four columns, so a full page will not have four full columns.
  I could do some higher math based on the default batch size and set
  a lower custom size for this view but haven't done so yet as it
  seems outside the scope of these "mechanical" changes.

* Go to
  https://launchpad.dev/~testing-spanish-team/+mailinglist-moderate
  Creating sample data was painful and done by hand based on the
  moderation.txt test.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/mailinglists/moderation.txt
  lib/lp/registry/stories/mailinglists/subscriptions.txt
  lib/canonical/launchpad/pagetitles.py
  lib/lp/registry/templates/team-mailinglist-moderate.pt
  lib/lp/registry/browser/team.py
  lib/lp/registry/templates/team-mailinglist-subscribers.pt
  lib/lp/registry/templates/teammembership-invitation.pt
  lib/lp/registry/browser/person.py

== Pylint notices ==

lib/lp/registry/browser/person.py
    119: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    120: [F0401] Unable to import 'lazr.config' (No module named config)
    121: [F0401] ...

  approve code ui

Nice conversion.

2009/9/14 Brad Crittenden <email address hidden>:
> Brad Crittenden has proposed merging lp:~bac/launchpad/bug-421986-team-list-pages into lp:launchpad/devel.
>
> Requested reviews:
>    Canonical Launchpad Engineering (launchpad)
>
> = Summary =
>
> Bug 421986 list three team pages that need mechanical updates for UI 3.0.
>
> == Proposed fix ==
>
> Provide changes to fulfill the new UI requirements.
>
> == Pre-implementation notes ==
>
> N/A
>
> == Implementation details ==
>
> * team-mailinglist-subscribers.pt
>  * Convert to use main_only layout.
>  * Move page title into the TeamMailingListSubscribersView as 'label'.
>  * Leave the hand-crafted table construction in the view since it
>    uses a four column presentation.  I could create a
>    four-column-list in the CSS if that is desired.  The current
>    approach works so I prefer to keep these changes minimal.
>
> * team-mailinglist-moderate.pt
>  * Convert to use main_only layout.
>  * Remove page title from pagetitles.py.  In
>    TeamMailingListModerationView keep the existing 'label'.
>
>
> * teammembership-invitation.pt
>  * Convert to use main_only layout.
>  * Move the pagetitle from pagetitles.py as 'label' and make
>    page_title be a synonym for it.  I *thought* having page_title was
>    not going to be required after Barry's changes but it is for this
>    view.
>
> == Tests ==
>
> bin/test -vvm lp.registry  -t stories/mailinglists/subscriptions.txt \
>     -t stories/mailinglists/moderation.txt
>
> == Demo and Q/A ==
>
> Screenshots are available at
> http://people.canonical.com/~bac/bug-421986-team-list-pages/
>
> * As Mark, go to https://launchpad.dev/~hwdb-team/+addmember and add
> 'testing-spanish-team'
>  Then go to:
>  https://launchpad.dev/~testing-spanish-team/+invitation/hwdb-team
>
> * Go to https://launchpad.dev/~testing-spanish-team/+mailing-list-subscribers
>  Note I for the screenshot I created a large team with lots of
>  subscribers *and* hacked the dev config to use a batching size of 50
>  (same as in production) rather than the normal 5 in the development
>  environment.  (If you'd like my script for creating the team with
>  mailing list subscribers using launchpadlib let me know.)
>
>  Also note I am unhappy that the default batch size is 50 but we're
>  using four columns, so a full page will not have four full columns.
>  I could do some higher math based on the default batch size and set
>  a lower custom size for this view but haven't done so yet as it
>  seems outside the scope of these "mechanical" changes.
>
> * Go to
>  https://launchpad.dev/~testing-spanish-team/+mailinglist-moderate
>  Creating sample data was painful and done by hand based on the
>  moderation.txt test.
>
> = Launchpad lint =
>
> Checking for conflicts. and issues in doctests and templates.
> Running jslint, xmllint, pyflakes, and pylint.
> Using normal rules.
>
> Linting changed files:
>  lib/lp/registry/stories/mailinglists/moderation.txt
>  lib/lp/registry/stories/mailinglists/subscriptions.txt
>  lib/canonical/launchpad/pagetitles.py
>  lib/lp/registry/templates/team-mailinglist-moderate.pt
>  lib/lp/registry/browser/team.py
>  lib/...

r=me
ui=me

Everything looks fine and dandy for a mechanical change, although it seems there are no breadcrumbs in: http://people.canonical.com/~bac/bug-421986-team-list-pages/team+invitation.png

Is there any reason for that?

bac - beuno: re: your question about breadcrumbs... the url https://launchpad.dev/~testing-spanish-team/+invitation/hwdb-team only has as single breadcrumb for the testing-spanish-team. the rest of the traversal does not generate any. if the breadcrumb list only has one element they are not displayed.

bac - beuno: so that's the explanation of the current behavior. what do you think the breadcrumb for that URL should be?

beuno - bac, good question. I'm in a call, waiting to go into another call, so I'd say land it for now

bac - ok, i'll answer in the MP. we can revisit as necessary.