Merge lp:~bac/launchpad/bug-432026-person-edit into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~bac/launchpad/bug-432026-person-edit | ||||
Merge into: | lp:launchpad | ||||
Diff against target: | None lines | ||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-432026-person-edit | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Canonical Launchpad Engineering | Pending | ||
Review via email: mp+11999@code.launchpad.net |
To post a comment you must log in.
= Summary =
The person-edit.pt template needs to be converted, as stated in bug 432026.
== Proposed fix ==
Simple conversion of the template and then fixing failed tests.
== Pre-implementation notes ==
Brief chat with Curtis.
== Implementation details ==
In the old page there were navigation lozenges that linked to lower edit pages, e.g.
for editing emails, wikiname, etc. A lot of the pagetest tested going to the 'Change
details' page and then navigating to correct page. The links to the individual edit
pages are now available off the person index page. The tests were changed to go
directly to the lower edit page, which saves a page load, which will make Julian happy.
A few tests were renamed for consistency.
== Tests ==
Run all of the registry tests:
bin/test -vvm lp.registry
== Demo and Q/A ==
https:/ /launchpad. dev/~mark and click on 'Change details'.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ stories/ mailinglists/ subscriptions. txt /launchpad/ pagetitles. py registry/ stories/ foaf/xx- validate- email.txt registry/ stories/ foaf/xx- add-sshkey. txt registry/ stories/ foaf/xx- set-preferredem ail.txt registry/ stories/ foaf/xx- add-email. txt registry/ stories/ gpg-coc/ 01-claimgpg. txt registry/ browser/ person. py registry/ templates/ person- edit.pt
lib/lp/
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ registry/ browser/ person. py interface' (No module named restful)
117: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
118: [F0401] Unable to import 'lazr.config' (No module named config)
119: [F0401] Unable to import 'lazr.restful.
--
Brad Crittenden
<email address hidden>