Launchpad itself

Merge lp:~bac/launchpad/bug-435599 into lp:launchpad

  1. bug-435599
  2. Merge into devel
Proposed by Brad Crittenden
Status: Merged
Approved by: Barry Warsaw
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~bac/launchpad/bug-435599
Merge into: lp:launchpad
Diff against target: 28 lines
1 file modified
lib/canonical/launchpad/templates/root-index.pt (+3/-3)
To merge this branch: bzr merge lp:~bac/launchpad/bug-435599
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
Review via email: mp+13141@code.launchpad.net

Commit message

Use permalink URLs for LP front page links to the blog.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

During the 3.0 release a link to the blog was broken because it used the id-based URL
rather than the longer human-readable, permalink URL. This is described in bug 4335599.

== Proposed fix ==

The change here is trivial to use the longer URLs. Hopefully getting the id-based
ones out of the template will discourage their future use.

== Pre-implementation notes ==

Chat with Curtis.

== Implementation details ==

Straightforward.

== Tests ==

No

== Demo and Q/A ==

Look at the front page and ensure the new URLs are used.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/templates/root-index.pt

Revision history for this message
Barry Warsaw (barry) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/templates/root-index.pt'
2--- lib/canonical/launchpad/templates/root-index.pt 2009-09-24 10:57:33 +0000
3+++ lib/canonical/launchpad/templates/root-index.pt 2009-10-14 13:51:15 +0000
4@@ -79,13 +79,13 @@
5 Find out what's new in the latest version of Launchpad.
6 </li>
7 <li class="news">
8- <a href="http://blog.launchpad.net/?p=1019">
9+ <a href="http://blog.launchpad.net/general/talking-about-launchpads-new-interface">
10 Talking about Launchpad's new UI</a><span class="blogdate"> &ndash; 23 Sep 2009</span><br />
11 Martin Albisetti &mdash; Launchpad's design guy &mdash; on the new
12 web interface.
13 </li>
14 <li class="news">
15- <a href="http://blog.launchpad.net/?p=1021">
16+ <a href="http://blog.launchpad.net/general/under-the-hood">
17 Under the hood</a><span class="blogdate"> &ndash; 23 Sep 2009</span><br />
18 Bj&ouml;rn Tillenius &mdash; Launchpad technical architect &mdash; talks
19 about the inner workings of Launchpad.
20@@ -96,7 +96,7 @@
21 Get the code to Launchpad and join our development community.
22 </li>
23 <li class="news">
24- <a href="http://blog.launchpad.net/?p=551">
25+ <a href="http://blog.launchpad.net/general/new-privacy-features-for-commercial-subscribers">
26 Launchpad for commercial projects</a><span class="blogdate"> &ndash; 25 Feb 2009</span><br />
27 Find out more about Launchpad's privacy features for your commercial projects.
28 </li>