Merge lp:~bac/launchpad/bug-591345 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10994 | ||||
Proposed branch: | lp:~bac/launchpad/bug-591345 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
119 lines (+60/-5) 2 files modified
lib/lp/bugs/browser/tests/test_bugsupervisor.py (+58/-1) lib/lp/bugs/interfaces/bugsupervisor.py (+2/-4) |
||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-591345 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+27084@code.launchpad.net |
Commit message
Allow private teams to be set as bug supervisor in the web interface.
Description of the change
= Summary =
A private team should be allowed to be a bug supervisor but due to a
regression in the interface private teams are not allowed.
== Proposed fix ==
Change the widget to be a ParticipatingPe
== Pre-implementation notes ==
Chat with Curtis.
== Implementation details ==
As above.
== Tests ==
bin/test -vvm lp.bugs -t test_bugsupervisor
== Demo and Q/A ==
Create a private team and assign it as a bug supervisor to a project you
own.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
This is great. Thanks for getting this fixed at short notice.