Launchpad itself

Merge lp:~barry/launchpad/434072-spec-index into lp:launchpad

  1. 434072-spec-index
  2. Merge into devel
Proposed by Barry Warsaw
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~barry/launchpad/434072-spec-index
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~barry/launchpad/434072-spec-index
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical Approve
Aaron Bentley (community) Approve
Review via email: mp+12175@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

 reviewer abentley

= Summary =

Very simple conversion of specifications-index.pt
(i.e. http://blueprints.launchpad.* +index page) to UI 3.0.

== Proposed fix ==

Convert the template, update the test, move the label from the template to the
view.

== Pre-implementation notes ==

None. I can do these in my sleep.

== Implementation details ==

Nothing special. This will be an RC.

== Tests ==

bin/test -vv -t stories/blueprints

== Demo and Q/A ==

http://blueprints.launchpad.dev

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/blueprints/stories/blueprints/xx-index.txt
  lib/lp/blueprints/browser/specification.py
  lib/lp/blueprints/templates/specifications-index.pt

== Pyflakes notices ==

lib/lp/blueprints/browser/specification.py
    56: 'smartquote' imported but unused

Craptastic. I'll fix this before landing.

== Pylint notices ==

lib/lp/blueprints/browser/specification.py
    56: [W0611] Unused import smartquote

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review approve

Looks straightforward.

Barry Warsaw wrote:
> Barry Warsaw has proposed merging lp:~barry/launchpad/434072-spec-index into lp:launchpad/devel.
>
> Requested reviews:
> Aaron Bentley (abentley)
>
> reviewer abentley
>
> = Summary =
>
> Very simple conversion of specifications-index.pt
> (i.e. http://blueprints.launchpad.* +index page) to UI 3.0.
>
>
> == Proposed fix ==
>
> Convert the template, update the test, move the label from the template to the
> view.
>
>
> == Pre-implementation notes ==
>
> None. I can do these in my sleep.
>
>
> == Implementation details ==
>
> Nothing special. This will be an RC.
>
>
> == Tests ==
>
> bin/test -vv -t stories/blueprints
>
>
> == Demo and Q/A ==
>
> http://blueprints.launchpad.dev
>
>
> = Launchpad lint =
>
> Checking for conflicts. and issues in doctests and templates.
> Running jslint, xmllint, pyflakes, and pylint.
> Using normal rules.
>
> Linting changed files:
> lib/lp/blueprints/stories/blueprints/xx-index.txt
> lib/lp/blueprints/browser/specification.py
> lib/lp/blueprints/templates/specifications-index.pt
>
>
> == Pyflakes notices ==
>
> lib/lp/blueprints/browser/specification.py
> 56: 'smartquote' imported but unused
>
> Craptastic. I'll fix this before landing.
>
>
> == Pylint notices ==
>
> lib/lp/blueprints/browser/specification.py
> 56: [W0611] Unused import smartquote
>
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkq3uz4ACgkQ0F+nu1YWqI3oRQCePFSp5gqgarTjnDsSEa0BUEXL
gDUAnj1r9aun84pnGDbN38TGs+UtYmwC
=+og7
-----END PGP SIGNATURE-----

review: Approve
Revision history for this message
Brad Crittenden (bac) :
review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/blueprints/browser/specification.py'
2--- lib/lp/blueprints/browser/specification.py 2009-09-19 08:58:42 +0000
3+++ lib/lp/blueprints/browser/specification.py 2009-09-21 17:21:57 +0000
4@@ -1206,6 +1206,8 @@
5 class SpecificationSetView(AppFrontPageSearchView, HasSpecificationsView):
6 """View for the Blueprints index page."""
7
8+ label = 'Blueprints'
9+
10 @safe_action
11 @action('Find blueprints', name="search")
12 def search_action(self, action, data):
13
14=== modified file 'lib/lp/blueprints/stories/blueprints/xx-index.txt'
15--- lib/lp/blueprints/stories/blueprints/xx-index.txt 2009-05-11 18:19:21 +0000
16+++ lib/lp/blueprints/stories/blueprints/xx-index.txt 2009-09-21 17:21:57 +0000
17@@ -1,4 +1,6 @@
18-= Blueprints index page =
19+=====================
20+Blueprints index page
21+=====================
22
23 The blueprints index page allows users to search for blueprints within
24 a single Launchpad project or across all projects.
25@@ -7,6 +9,7 @@
26
27 >>> user_browser.open('http://blueprints.launchpad.dev/')
28 >>> print extract_text(find_main_content(user_browser.contents))
29+ Blueprints
30 All projects...
31 Recently registered
32 The Krunch Desktop Plan
33
34=== modified file 'lib/lp/blueprints/templates/specifications-index.pt'
35--- lib/lp/blueprints/templates/specifications-index.pt 2009-07-17 17:59:07 +0000
36+++ lib/lp/blueprints/templates/specifications-index.pt 2009-09-21 17:21:57 +0000
37@@ -3,13 +3,9 @@
38 xmlns:tal="http://xml.zope.org/namespaces/tal"
39 xmlns:metal="http://xml.zope.org/namespaces/metal"
40 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
41- xml:lang="en"
42- lang="en"
43- dir="ltr"
44- metal:use-macro="view/macro:page/applicationhome"
45+ metal:use-macro="view/macro:page/main_only"
46 i18n:domain="launchpad">
47 <body>
48- <h1 metal:fill-slot="heading">Blueprint tracking</h1>
49 <div metal:fill-slot="main">
50
51 <ul class="buttons">