RT: Request Tracker

rt:5.0/jschart-avoid-duplicated-criteria

  1. Git
  2. lp:rt
  3. 5.0/jschart-avoid-duplicated-criteria
Last commit made on 2022-10-24
Get this branch:
git clone -b 5.0/jschart-avoid-duplicated-criteria https://git.launchpad.net/rt

Branch merges

Branch information

Name:
5.0/jschart-avoid-duplicated-criteria
Repository:
lp:rt

Recent commits

eccfa6e... by sunnavy

Avoid adding duplicated criteria to queries generated in JSChart

For a bar chart grouped by status, each bar represents one status, and
clicking it redirects to search result page that shows tickets with that
status only. This is achieved by adding the extra status criterion to
the original query, e.g. TicketSQL is changed from:

    Queue = 'General'

to

    ( Queue = 'General' ) AND ( (Status = 'new') )

If you go to Chart page and click again, previously we unconditionally
added the extra status criterion, so the TicketSQL would be

    ( Queue = 'General' ) AND ( (Status = 'new') ) AND ( (Status = 'new') )

which is unnecessary. This commit checks the queries beforehand to avoid
the duplication.

d740e2c... by Jim Brandt

Merge branch '5.0/asset-custom-roles' into 5.0-trunk

a126faf... by Shawn M Moore <email address hidden>

Add API and web tests for interacting with custom roles on assets

a25e815... by sunnavy

Relax requirements about role names to be unique for each lookup type

76f93bf... by sunnavy

Support custom roles for asset searches

9c386ad... by sunnavy

Show single custom role's name in the result message of adding members

This is for asset custom roles, tickets don't have this issue as the
result message was customized in RT::Ticket already.

34ec521... by sunnavy

Clear old data when registering the whole custom roles

RegisterRoles is used to refresh custom roles in
RT::Interface::Web::MaybeRebuildCustomRolesCache, but previously it just
updated enabled ones and wrongly ignored disabled/deleted ones.

This commit updates the logic to remove existing custom roles first and
then fill new data from scratch, which fixes the issue.

65e82c6... by Shawn M Moore <email address hidden>

Exclude asset custom roles from ticket search

This covers both search builder and bulk update.

c8911b2... by Jim Brandt

Add lookup type to custom role admin page listing

4598f1a... by Shawn M Moore <email address hidden>

Add custom roles to assets