loggerhead

Merge lp:~beuno/loggerhead/yui3-0-0 into lp:loggerhead

  1. yui3-0-0
  2. Merge into trunk-rich
Proposed by Martin Albisetti
Status: Merged
Merged at revision: 445
Proposed branch: lp:~beuno/loggerhead/yui3-0-0
Merge into: lp:loggerhead
To merge this branch: bzr merge lp:~beuno/loggerhead/yui3-0-0
Reviewer Review Type Date Requested Status
Max Kanat-Alexander (community) Approve
Matt Nordhoff Abstain
Review via email: mp+13744@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Albisetti (beuno) wrote :

This branch upgrades loggerhead to YUI 3.0.0 final.
Everything I can test works, although this change does introduce a problem when rendering search results, it renders them in the wrong place. I intend to fix that, but I'd rather try and get this branch in as soon as possible.

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

I just played around with this a little, and everything worked (aside from the search bug, obviously).

But I know nothing about YUI, and not very much about JavaScript, so I'm not fit to review this.

I'm -0 on merging this before the search bug is fixed. I won't stop you, but I'd prefer the trunk remain as bug-free as possible, especially since the YUI upgrade doesn't really have an impact on users, and that bug does.

review: Abstain
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Is this merge proposal now obsolete?

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I'm not sure that it is, embarrassingly enough -- we're still on pr2

Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

I have reviewed this and it seems correct from my testing and ready for merging. I am familiar with YUI and qualified to do this review.

I will do the merge myself, since this branch is so old.

review: Approve

Subscribers

People subscribed via source and target branches