Launchpad itself

Merge lp:~bjornt/launchpad/jscheck-all-layers into lp:launchpad

  1. jscheck-all-layers
  2. Merge into devel
Proposed by Björn Tillenius
Status: Merged
Merged at revision: not available
Proposed branch: lp:~bjornt/launchpad/jscheck-all-layers
Merge into: lp:launchpad
Diff against target: 15 lines
1 file modified
Makefile (+1/-4)
To merge this branch: bzr merge lp:~bjornt/launchpad/jscheck-all-layers
Reviewer Review Type Date Requested Status
Abel Deuring (community) Approve
Review via email: mp+13113@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Björn Tillenius (bjornt) wrote :

'make jscheck' currently run bin/test multiple times; once for each
Windmill layer we have. This has the effect that if one test fails in a
layer, the tests in the next layers won't be run.

This branch changes 'make check' to invoke bin/test only once. Instead
of specifying each layer individually, I chose to specify WindmillLayer,
which will match all layers containing the string WindmillLayer, so that
people don't have to bother modifying the jscheck target when adding new
layers.

--
Björn Tillenius | https://launchpad.net/~bjornt

Revision history for this message
Abel Deuring (adeuring) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2009-10-09 15:26:50 +0000
3+++ Makefile 2009-10-13 11:43:13 +0000
4@@ -90,10 +90,7 @@
5 @echo
6 @echo "Running the JavaScript integration test suite"
7 @echo
8- bin/test $(VERBOSITY) --layer=BugsWindmillLayer
9- bin/test $(VERBOSITY) --layer=CodeWindmillLayer
10- bin/test $(VERBOSITY) --layer=RegistryWindmillLayer
11- bin/test $(VERBOSITY) --layer=SoyuzWindmillLayer
12+ bin/test $(VERBOSITY) --layer=WindmillLayer
13
14 jscheck_functest: build
15 # Run the old functest Windmill integration tests. The test runner