Launchpad itself

Merge lp:~brian-murray/launchpad/api-export-messages-count into lp:launchpad

  1. api-export-messages-count
  2. Merge into devel
Proposed by Brian Murray
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~brian-murray/launchpad/api-export-messages-count
Merge into: lp:launchpad
Diff against target: 28 lines (+4/-3)
2 files modified
lib/lp/bugs/interfaces/bug.py (+3/-3)
lib/lp/bugs/stories/webservice/xx-bug.txt (+1/-0)
To merge this branch: bzr merge lp:~brian-murray/launchpad/api-export-messages-count
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+22833@code.launchpad.net

Commit message

Export the message_count of a bug in the API.

Description of the change

This branch exports the message_count for a bug in the API.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Brian this change looks fine. I'm curious, though, what happened to the previous branch that made this fix but was never landed?

Also you don't say whether you had a pre-implementation call or not. Just a reminder that any change requires a pre-imp call with a member of the Launchpad team for the specific application.

review: Needs Information (code)
Revision history for this message
Brian Murray (brian-murray) wrote :

Tom and I had tried to land the previous branch with some other API changes to bug that I had made but they ended up conflicting with each other. Tom and I did discuss this at the Launchpad Bugs sprint in Auburn in January.

Revision history for this message
Brad Crittenden (bac) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/interfaces/bug.py'
2--- lib/lp/bugs/interfaces/bug.py 2010-03-12 06:24:59 +0000
3+++ lib/lp/bugs/interfaces/bug.py 2010-04-05 21:02:31 +0000
4@@ -288,9 +288,9 @@
5 number_of_duplicates = exported(
6 Int(title=_('The number of bugs marked as duplicates of this bug'),
7 required=True, readonly=True))
8- message_count = Int(
9- title=_('The number of comments on this bug'),
10- required=True, readonly=True)
11+ message_count = exported(
12+ Int(title=_('The number of comments on this bug'),
13+ required=True, readonly=True))
14 users_affected_count = exported(
15 Int(title=_('The number of users affected by this bug '
16 '(not including duplicates)'),
17
18=== modified file 'lib/lp/bugs/stories/webservice/xx-bug.txt'
19--- lib/lp/bugs/stories/webservice/xx-bug.txt 2010-03-24 21:59:44 +0000
20+++ lib/lp/bugs/stories/webservice/xx-bug.txt 2010-04-05 21:02:31 +0000
21@@ -34,6 +34,7 @@
22 id: 11
23 latest_patch_uploaded: None
24 linked_branches_collection_link: u'http://.../bugs/11/linked_branches'
25+ message_count: 7
26 messages_collection_link: u'http://.../bugs/11/messages'
27 name: None
28 number_of_duplicates: 0