Launchpad itself

Merge lp:~brian-murray/launchpad/api-export-person-logo_link into lp:launchpad

  1. api-export-person-logo_link
  2. Merge into devel
Proposed by Brian Murray
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~brian-murray/launchpad/api-export-person-logo_link
Merge into: lp:launchpad
Diff against target: 47 lines (+11/-8)
2 files modified
lib/lp/registry/interfaces/person.py (+9/-8)
lib/lp/registry/stories/webservice/xx-person.txt (+2/-0)
To merge this branch: bzr merge lp:~brian-murray/launchpad/api-export-person-logo_link
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) code Approve
Review via email: mp+20074@code.launchpad.net

Commit message

Export Person.logo in the API.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This exports logo for people and team's in the API.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Can't think of anything that could go wrong, except perhaps tests breaking—and our process will catch that.

Thanks for the fix!

review: Approve (code)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

I just kicked off an "ec2 land" for this branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/interfaces/person.py'
2--- lib/lp/registry/interfaces/person.py 2010-02-08 14:37:50 +0000
3+++ lib/lp/registry/interfaces/person.py 2010-02-24 17:36:33 +0000
4@@ -508,14 +508,15 @@
5 "in listings of bugs or on a person's membership table."))
6 iconID = Int(title=_('Icon ID'), required=True, readonly=True)
7
8- logo = LogoImageUpload(
9- title=_("Logo"), required=False,
10- default_image_resource='/@@/person-logo',
11- description=_(
12- "An image of exactly 64x64 pixels that will be displayed in "
13- "the heading of all pages related to you. Traditionally this "
14- "is a logo, a small picture or a personal mascot. It should be "
15- "no bigger than 50kb in size."))
16+ logo = exported(
17+ LogoImageUpload(
18+ title=_("Logo"), required=False,
19+ default_image_resource='/@@/person-logo',
20+ description=_(
21+ "An image of exactly 64x64 pixels that will be displayed in "
22+ "the heading of all pages related to you. Traditionally this "
23+ "is a logo, a small picture or a personal mascot. It should be "
24+ "no bigger than 50kb in size.")))
25 logoID = Int(title=_('Logo ID'), required=True, readonly=True)
26
27 mugshot = exported(MugshotImageUpload(
28
29=== modified file 'lib/lp/registry/stories/webservice/xx-person.txt'
30--- lib/lp/registry/stories/webservice/xx-person.txt 2010-02-05 09:02:39 +0000
31+++ lib/lp/registry/stories/webservice/xx-person.txt 2010-02-24 17:36:33 +0000
32@@ -28,6 +28,7 @@
33 karma: 0
34 languages_collection_link: u'http://.../~salgado/languages'
35 latitude: None
36+ logo_link: u'http://.../~salgado/logo'
37 longitude: None
38 mailing_list_auto_subscribe_policy: u'Ask me when I join a team'
39 members_collection_link: u'http://.../~salgado/members'
40@@ -74,6 +75,7 @@
41 karma: 0
42 languages_collection_link: u'http://.../~ubuntu-team/languages'
43 latitude: None
44+ logo_link: u'http://.../~ubuntu-team/logo'
45 longitude: None
46 mailing_list_auto_subscribe_policy: u'Ask me when I join a team'
47 members_collection_link: u'http://.../~ubuntu-team/members'