ubuntu-archive-tools

Merge lp:~brian-murray/ubuntu-archive-tools/sru-review-versioned-debdiffs into lp:ubuntu-archive-tools

  1. sru-review-versioned-debdiffs
  2. Merge into trunk
Proposed by Brian Murray
Status: Merged
Merged at revision: 1499
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/sru-review-versioned-debdiffs
Merge into: lp:ubuntu-archive-tools
Diff against target: 19 lines (+6/-2)
1 file modified
sru-review (+6/-2)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/sru-review-versioned-debdiffs
Reviewer Review Type Date Requested Status
Steve Langasek Needs Information
Łukasz Zemczak Pending
Review via email: mp+406597@code.launchpad.net

Description of the change

I was trying to use sru-review to check on something in the Rejected queue and kept getting the debdiff for 2.664.26 even though I wanted the one for 2.664.25. Here's the command I was using:

./sru-review -q Rejected -e 2.664.25 -s focal --no-browser livecd-rootfs

This MP will fix that by adding the version passed on the command line to the debdiff regular expression.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
lp:~brian-murray/ubuntu-archive-tools/sru-review-versioned-debdiffs updated
1493. By Brian Murray

reduce code duplication

1494. By Brian Murray

fix a typo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-review'
2--- sru-review 2021-08-05 23:17:59 +0000
3+++ sru-review 2021-08-26 20:51:29 +0000
4@@ -164,10 +164,14 @@
5
6 if options.diff:
7 oops_re = re.compile('class="oopsid">(OOPS[a-zA-Z0-9-]+)<')
8+ if version:
9+ re_version = re.escape(version)
10+ else:
11+ re_version = '[^_"]+'
12 debdiff_re = re.compile(
13 'href="(http://launchpadlibrarian.net/'
14- '\d+/%s_[^"_]+_[^_"]+\.diff\.gz)">\s*diff from' %
15- re.escape(sourcepkg))
16+ '\d+/%s_[^"_]+_%s\.diff\.gz)">\s*diff from' %
17+ (re.escape(sourcepkg), re_version))
18
19 queue_html = urlopen(queue_url).read().decode('utf-8')
20

Subscribers

People subscribed via source and target branches