224f490...
by
Haiyang Zhang
on 2024-05-24
net: mana: Fix Rx DMA datasize and skb_over_panic
BugLink: https:/ /bugs.launchpad .net/bugs/ 2066992
mana_get_ rxbuf_cfg( ) aligns the RX buffer's DMA datasize to be
multiple of 64. So a packet slightly bigger than mtu+14, say 1536,
can be received and cause skb_over_panic.
Sample dmesg:
[ 5325.237162] skbuff: skb_over_panic: text:ffffffffc0 43277a len:1536 put:1536 head:ff1100018b 517000 data:ff1100018b 517100 tail:0x700 end:0x6ea dev:<NULL>
[ 5325.243689] ------------[ cut here ]------------
[ 5325.245748] kernel BUG at net/core/ skbuff. c:192!
[ 5325.247838] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
[ 5325.258374] RIP: 0010:skb_ panic+0x4f/ 0x60
[ 5325.302941] Call Trace:
[ 5325.304389] <IRQ>
[ 5325.315794] ? skb_panic+0x4f/0x60
[ 5325.317457] ? asm_exc_ invalid_ op+0x1f/ 0x30
[ 5325.319490] ? skb_panic+0x4f/0x60
[ 5325.321161] skb_put+0x4e/0x50
[ 5325.322670] mana_poll+ 0x6fa/0xb50 [mana]
[ 5325.324578] __napi_ poll+0x33/ 0x1e0
[ 5325.326328] net_rx_ action+ 0x12e/0x280
As discussed internally, this alignment is not necessary. To fix
this bug, remove it from the code. So oversized packets will be
marked as CQE_RX_TRUNCATED by NIC, and dropped.
Cc: <email address hidden>
Fixes: 2fbbd712baf1 ("net: mana: Enable RX path to handle various MTU sizes")
Signed-off-by: Haiyang Zhang <email address hidden>
Reviewed-by: Dexuan Cui <email address hidden>
Link: https://<email address hidden>
Signed-off-by: Jakub Kicinski <email address hidden>
(cherry picked from commit c0de6ab920aafb5 6feab56058e46b6 88e694a246)
Signed-off-by: John Cabaj <email address hidden>
Acked-by: Guoqing Jiang <email address hidden>
Acked-by: Tim Gardner <email address hidden>
Acked-by: Paolo Pisati <email address hidden>
Signed-off-by: John Cabaj <email address hidden>
1fe0b37...
by
Haiyang Zhang
on 2024-05-23
net: mana: Enable MANA driver on ARM64 with 4K page size
BugLink: https:/ /bugs.launchpad .net/bugs/ 2066982
Change the Kconfig dependency, so this driver can be built and run on ARM64
with 4K page size.
16/64K page sizes are not supported yet.
Signed-off-by: Haiyang Zhang <email address hidden>
Link: https://<email address hidden>
Signed-off-by: Jakub Kicinski <email address hidden>
(cherry picked from commit 40a1d11fc670ac0 3c5dc2e5a9724b3 30e74f38b0)
Signed-off-by: John Cabaj <email address hidden>
Acked-by: Tim Gardner <email address hidden>
Acked-by: Paolo Pisati <email address hidden>
Signed-off-by: John Cabaj <email address hidden>
5d01667...
by
Tim Gardner
on 2024-05-17
UBUNTU: Ubuntu- azure-6. 8.0-1008. 8
Signed-off-by: Tim Gardner <email address hidden>
7ead445...
by
Tim Gardner
on 2024-05-17
UBUNTU: link-to-tracker: update tracking bug
BugLink: https:/ /bugs.launchpad .net/bugs/ 2064327
Properties: no-test-build
Signed-off-by: Tim Gardner <email address hidden>
6aaf4e6...
by
Tim Gardner
on 2024-05-17
UBUNTU: Start new release
Ignore: yes
Signed-off-by: Tim Gardner <email address hidden>
ae4ba20...
by
Shradha Gupta <email address hidden>
on 2024-02-02
drm: Check polling initialized before enabling in drm_helper_ probe_single_ connector_ modes
BugLink: https:/ /bugs.launchpad .net/bugs/ 2064740
In function drm_helper_ probe_single_ connector_ modes() when we enable
polling again, if it is already uninitialized, a warning is reported.
This patch fixes the warning message by checking if poll is initialized
before enabling it.
Reported-by: kernel test robot <email address hidden>
Closes: https://<email address hidden>
Signed-off-by: Shradha Gupta <email address hidden>
Signed-off-by: Daniel Vetter <email address hidden>
Link: https:/ /patchwork. freedesktop <email address hidden>
(cherry picked from commit 048a36d8a6085bb d8ab9e5794b713b 92ac986450)
Signed-off-by: Tim Gardner <email address hidden>
Acked-by: John Cabaj <email address hidden>
Acked-by: Philip Cox <email address hidden>
Signed-off-by: Tim Gardner <email address hidden>
8838791...
by
Shradha Gupta <email address hidden>
on 2024-02-02
drm: Check output polling initialized before disabling
BugLink: https:/ /bugs.launchpad .net/bugs/ 2064740
In drm_kms_ helper_ poll_disable( ) check if output polling
support is initialized before disabling polling. If not flag
this as a warning.
Additionally in drm_mode_ config_ helper_ suspend( ) and
drm_mode_ config_ helper_ resume( ) calls, that re the callers of these
functions, avoid invoking them if polling is not initialized.
For drivers like hyperv-drm, that do not initialize connector
polling, if suspend is called without this check, it leads to
suspend failure with following stack
[ 770.719392] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[ 770.720592] printk: Suspending console(s) (use no_console_suspend to debug)
[ 770.948823] ------------[ cut here ]------------
[ 770.948824] WARNING: CPU: 1 PID: 17197 at kernel/ workqueue. c:3162 __flush_ work.isra. 0+0x212/ 0x230
[ 770.948831] Modules linked in: rfkill nft_counter xt_conntrack xt_owner udf nft_compat crc_itu_t nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink vfat fat mlx5_ib ib_uverbs ib_core mlx5_core intel_rapl_msr intel_rapl_common kvm_amd ccp mlxfw kvm psample hyperv_drm tls drm_shmem_helper drm_kms_helper irqbypass pcspkr syscopyarea sysfillrect sysimgblt hv_balloon hv_utils joydev drm fuse xfs libcrc32c pci_hyperv pci_hyperv_intf sr_mod sd_mod cdrom t10_pi sg hv_storvsc scsi_transport_fc hv_netvsc serio_raw hyperv_keyboard hid_hyperv crct10dif_pclmul crc32_pclmul crc32c_intel hv_vmbus ghash_clmulni_intel dm_mirror dm_region_hash dm_log dm_mod
[ 770.948863] CPU: 1 PID: 17197 Comm: systemd-sleep Not tainted 5.14.0- 362.2.1. el9_3.x86_ 64 #1
[ 770.948865] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS Hyper-V UEFI Release v4.1 05/09/2022
[ 770.948866] RIP: 0010:__ flush_work. isra.0+ 0x212/0x230
[ 770.948869] Code: 8b 4d 00 4c 8b 45 08 89 ca 48 c1 e9 04 83 e2 08 83 e1 0f 83 ca 02 89 c8 48 0f ba 6d 00 03 e9 25 ff ff ff 0f 0b e9 4e ff ff ff <0f> 0b 45 31 ed e9 44 ff ff ff e8 8f 89 b2 00 66 66 2e 0f 1f 84 00
[ 770.948870] RSP: 0018:ffffaf4ac2 13fb10 EFLAGS: 00010246
[ 770.948871] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff8c992857
[ 770.948872] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffff9aad82b00330
[ 770.948873] RBP: ffff9aad82b00330 R08: 0000000000000000 R09: ffff9aad87ee3d10
[ 770.948874] R10: 0000000000000200 R11: 0000000000000000 R12: ffff9aad82b00330
[ 770.948874] R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001
[ 770.948875] FS: 00007ff1b2f6bb4 0(0000) GS:ffff9aaf37d0 0000(0000) knlGS:000000000 0000000
[ 770.948878] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 770.948878] CR2: 0000555f345cb666 CR3: 00000001462dc005 CR4: 0000000000370ee0
[ 770.948879] Call Trace:
[ 770.948880] <TASK>
[ 770.948881] ? show_trace_ log_lvl+ 0x1c4/0x2df
[ 770.948884] ? show_trace_ log_lvl+ 0x1c4/0x2df
[ 770.948886] ? __cancel_ work_timer+ 0x103/0x190
[ 770.948887] ? __flush_ work.isra. 0+0x212/ 0x230
[ 770.948889] ? __warn+0x81/0x110
[ 770.948891] ? __flush_ work.isra. 0+0x212/ 0x230
[ 770.948892] ? report_ bug+0x10a/ 0x140
[ 770.948895] ? handle_ bug+0x3c/ 0x70
[ 770.948898] ? exc_invalid_ op+0x14/ 0x70
[ 770.948899] ? asm_exc_ invalid_ op+0x16/ 0x20
[ 770.948903] ? __flush_ work.isra. 0+0x212/ 0x230
[ 770.948905] __cancel_ work_timer+ 0x103/0x190
[ 770.948907] ? _raw_spin_ unlock_ irqrestore+ 0xa/0x30
[ 770.948910] drm_kms_ helper_ poll_disable+ 0x1e/0x40 [drm_kms_helper]
[ 770.948923] drm_mode_ config_ helper_ suspend+ 0x1c/0x80 [drm_kms_helper]
[ 770.948933] ? __pfx_vmbus_ suspend+ 0x10/0x10 [hv_vmbus]
[ 770.948942] hyperv_ vmbus_suspend+ 0x17/0x40 [hyperv_drm]
[ 770.948944] ? __pfx_vmbus_ suspend+ 0x10/0x10 [hv_vmbus]
[ 770.948951] dpm_run_ callback+ 0x4c/0x140
[ 770.948954] __device_ suspend_ noirq+0x74/ 0x220
[ 770.948956] dpm_noirq_ suspend_ devices+ 0x148/0x2a0
[ 770.948958] dpm_suspend_ end+0x54/ 0xe0
[ 770.948960] create_ image+0x14/ 0x290
[ 770.948963] hibernation_ snapshot+ 0xd6/0x200
[ 770.948964] hibernate. cold+0x8b/ 0x1fb
[ 770.948967] state_store+ 0xcd/0xd0
[ 770.948969] kernfs_ fop_write_ iter+0x124/ 0x1b0
[ 770.948973] new_sync_ write+0xff/ 0x190
[ 770.948976] vfs_write+ 0x1ef/0x280
[ 770.948978] ksys_write+ 0x5f/0xe0
[ 770.948979] do_syscall_ 64+0x5c/ 0x90
[ 770.948981] ? syscall_ exit_work+ 0x103/0x130
[ 770.948983] ? syscall_ exit_to_ user_mode+ 0x12/0x30
[ 770.948985] ? do_syscall_ 64+0x69/ 0x90
[ 770.948986] ? do_syscall_ 64+0x69/ 0x90
[ 770.948987] ? do_user_ addr_fault+ 0x1d6/0x6a0
[ 770.948989] ? do_syscall_ 64+0x69/ 0x90
[ 770.948990] ? exc_page_ fault+0x62/ 0x150
[ 770.948992] entry_SYSCALL_ 64_after_ hwframe+ 0x72/0xdc
[ 770.948995] RIP: 0033:0x7ff1b293eba7
[ 770.949010] Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24
[ 770.949011] RSP: 002b:00007ffde3 912128 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
[ 770.949012] RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 00007ff1b293eba7
[ 770.949013] RDX: 0000000000000005 RSI: 00007ffde3912210 RDI: 0000000000000004
[ 770.949014] RBP: 00007ffde3912210 R08: 000055d7dd4c9510 R09: 00007ff1b29b14e0
[ 770.949014] R10: 00007ff1b29b13e0 R11: 0000000000000246 R12: 0000000000000005
[ 770.949015] R13: 000055d7dd4c53e0 R14: 0000000000000005 R15: 00007ff1b29f69e0
[ 770.949016] </TASK>
[ 770.949017] ---[ end trace e6fa0618bfa2f31d ]---
Built-on: Rhel9, Ubuntu22
Signed-off-by: Shradha Gupta <email address hidden>
Signed-off-by: Daniel Vetter <email address hidden>
Link: https:/ /patchwork. freedesktop <email address hidden>
(cherry picked from commit 5abffb66d12bcac 84bf7b66389c571 b8bb6e82bd)
Signed-off-by: Tim Gardner <email address hidden>
Acked-by: John Cabaj <email address hidden>
Acked-by: Philip Cox <email address hidden>
Signed-off-by: Tim Gardner <email address hidden>
a260c04...
by
Andrea Righi
on 2024-04-19
UBUNTU: Ubuntu- azure-6. 8.0-1007. 7
Signed-off-by: Andrea Righi <email address hidden>
ab549df...
by
Andrea Righi
on 2024-04-19
UBUNTU: [Config] azure: update toolchain version in annotations
Signed-off-by: Andrea Righi <email address hidden>
b1538ff...
by
Andrea Righi
on 2024-04-19
UBUNTU: [Packaging] debian. azure/dkms- versions -- update from kernel-versions (main/d2024.04.04)
BugLink: https:/ /bugs.launchpad .net/bugs/ 1786013
Signed-off-by: Andrea Righi <email address hidden>