DBus Menu

Merge lp:~charlesk/libdbusmenu/disconnect-menuitem-shown into lp:libdbusmenu/0.6

  1. disconnect-menuitem-shown
  2. Merge into trunk.0.6
Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 409
Merged at revision: 409
Proposed branch: lp:~charlesk/libdbusmenu/disconnect-menuitem-shown
Merge into: lp:libdbusmenu/0.6
Diff against target: 10 lines (+1/-0)
1 file modified
libdbusmenu-glib/server.c (+1/-0)
To merge this branch: bzr merge lp:~charlesk/libdbusmenu/disconnect-menuitem-shown
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+101454@code.launchpad.net

Description of the change

In menuitem_signals_remove(), disconnect the DBUSMENU_MENUITEM_SIGNAL_SHOW_TO_USER event that we connected to in menuitem_signals_create().

It looks like this non-disconnected signal goes all the way back to July 2010 <http://bazaar.launchpad.net/~dbusmenu-team/dbusmenu/trunk.0.6/revision/139#libdbusmenu-glib/server.c> so I'd like ted's eyes on this to confirm there's not some nuance that I'm missing...

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/server.c'
2--- libdbusmenu-glib/server.c 2012-04-09 15:09:41 +0000
3+++ libdbusmenu-glib/server.c 2012-04-10 23:00:25 +0000
4@@ -1288,6 +1288,7 @@
5 g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_child_removed), data);
6 g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_child_moved), data);
7 g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_property_changed), data);
8+ g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_shown), data);
9 return;
10 }
11

Subscribers

People subscribed via source and target branches

to all changes: