lp:~charlesk/libdbusmenu/lp-953509
- Get this branch:
- bzr branch lp:~charlesk/libdbusmenu/lp-953509
Branch merges
- Michael Terry: Approve
- Lars Karlitski (community): Approve
-
Diff: 116 lines (+0/-51)1 file modifiedlibdbusmenu-gtk/parser.c (+0/-51)
Related bugs
Bug #953509: libdbusmenu-gtk crash in parser.c theme_changed_cb() | High | Fix Released |
Related blueprints
Branch information
Recent revisions
- 389. By Charles Kerr
-
Don't listen for "changed" events from the screen's default GtkIconTheme. Fixes lp bug #953509
The crash in #953509 was being caused by the last two lines of theme_changed_cb() (a) leaving a dangling handler id in priv.theme_
changed_ sig, and (b) not remembering the handler id of its own signal connection. However after testing I don't see any reason to keep any of the theme handling code at all. "But wait," you say. "How will our menu icons follow the theme changes?" It works in practice anyway because we always listen for property changes to our reference GtkImage, **and** we listen for property changes to its GtkImageMenuItem parent so that if the GtkImageMenuItem changes GtkImages we can stop listening to the old one and start listening to the new one.
- 388. By Charles Kerr
-
merge lp:~ted/dbusmenu/regex_merge to fix a warning that comes up a lot with unity-panel-service about not having a label.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:libdbusmenu/0.6