lp:~charlesk/libdbusmenu/lp-953509

Created by Charles Kerr and last modified
Get this branch:
bzr branch lp:~charlesk/libdbusmenu/lp-953509
Only Charles Kerr can upload to this branch. If you are Charles Kerr please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Charles Kerr
Project:
DBus Menu
Status:
Merged

Recent revisions

389. By Charles Kerr

Don't listen for "changed" events from the screen's default GtkIconTheme. Fixes lp bug #953509

The crash in #953509 was being caused by the last two lines of theme_changed_cb() (a) leaving a dangling handler id in priv.theme_changed_sig, and (b) not remembering the handler id of its own signal connection. However after testing I don't see any reason to keep any of the theme handling code at all.

"But wait," you say. "How will our menu icons follow the theme changes?" It works in practice anyway because we always listen for property changes to our reference GtkImage, **and** we listen for property changes to its GtkImageMenuItem parent so that if the GtkImageMenuItem changes GtkImages we can stop listening to the old one and start listening to the new one.

388. By Charles Kerr

merge lp:~ted/dbusmenu/regex_merge to fix a warning that comes up a lot with unity-panel-service about not having a label.

387. By Ted Gould

Don't ask for a reply if no one cares

386. By Ted Gould

0.5.94

385. By Ted Gould

Removing underscores in the ATK name

384. By Ted Gould

Making sure to disconnect theme changed handler universally

383. By Ted Gould

Making sure the ATK object name always gets set to the label if nothing else

382. By Ted Gould

0.5.93

381. By Ted Gould

Fixing a trivial annotation bug

380. By Ted Gould

Fixing resetting an icon numerous times

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:libdbusmenu/0.6
This branch contains Public information 
Everyone can see this information.

Subscribers