~cjwatson/apache2-charm:master

Last commit made on 2023-08-04
Get this branch:
git clone -b master https://git.launchpad.net/~cjwatson/apache2-charm
Only Colin Watson can upload to this branch. If you are Colin Watson please log in for upload directions.

Branch merges

Branch information

Name:
master
Repository:
lp:~cjwatson/apache2-charm

Recent commits

1af4da0... by Colin Watson

Add trailing slash to match balancer names exactly

Reviewed-on: https://code.launchpad.net/~cjwatson/apache2-charm/+git/apache2-charm/+merge/448077
Reviewed-by: Haw Loeung <email address hidden>

2b5cf25... by Colin Watson

Enable headers and proxy_http modules for balancer relation

Reviewed-on: https://code.launchpad.net/~cjwatson/apache2-charm/+git/apache2-charm/+merge/448174
Reviewed-by: Haw Loeung <email address hidden>

74399d8... by Colin Watson

Enable headers and proxy_http modules for balancer relation

`data/balancer.template` uses the `RequestHeader` directive (which
requires `mod_headers`) and `BalancerMember http://...` (which requires
`mod_proxy_http`). This can be worked around by explicitly configuring
both in `enable_modules`, but it would be better for the charm to do
this automatically.

b5b9ddb... by Colin Watson

Add trailing slash to match balancer names exactly

https://httpd.apache.org/docs/2.4/mod/mod_proxy.html#proxy says:

  A backend URL matches the configuration section if it begins with the
  the wildcard-url string, even if the last path segment in the
  directive only matches a prefix of the backend URL. For example,
  <Proxy "http://example.com/foo"> matches all of
  http://example.com/foo, http://example.com/foo/bar, and
  http://example.com/foobar. The matching of the final URL differs from
  the behavior of the <Location> section, which for purposes of this
  note treats the final path component as if it ended in a slash.

This caused me considerable confusion recently when working with a
combination of the apache2 and squid-reverseproxy charms: I had multiple
balancers available, including "launchpad-appserver-main" and
"launchpad-appserver-main-cached", and spent ages trying to figure out
why requests to balancer://launchpad-appserver-main-cached/... were sent
to Squid with "X-Balancer-Name: launchpad-appserver-main". Eventually I
noticed this paragraph in the Apache documentation and was able to work
around the problem by using the name "cached-launchpad-appserver-main"
instead, but I don't think I should have had to do this.

URLs aimed at balancers will always have some kind of path component as
well as the balancer name, so it should be safe to add a trailing slash
to ensure that the `<Proxy>` directive doesn't accidentally match other
balancer names by prefix.

01ac458... by Franco Luciano Forneron Buschiazzo

Mellon config files hotfix

Reviewed-on: https://code.launchpad.net/~gtrkiller/apache2-charm/+git/apache2-charm/+merge/440038
Reviewed-by: Tom Haddon <email address hidden>

18092db... by Franco Luciano Forneron Buschiazzo

config files name hotfix

98b9ea7... by Franco Luciano Forneron Buschiazzo

Add SAML provider logic

Reviewed-on: https://code.launchpad.net/~gtrkiller/apache2-charm/+git/apache2-charm/+merge/439406
Reviewed-by: Tom Haddon <email address hidden>

e3ba3ce... by Franco Luciano Forneron Buschiazzo

adding SAML provider logic

adding SAML provider logic

addressing comments

addressing comments

addressing comments

addressing comments

Formatting updates so lint passes

handling pre-focal failure gracefully

adding comment

4165c49... by Barry Price

Make all python calls explicitly python2, to avoid any ambiguity when we finally port this to python3

Reviewed-on: https://code.launchpad.net/~barryprice/apache2-charm/+git/apache2-charm/+merge/428313
Reviewed-by: Haw Loeung <email address hidden>

bffdf75... by Barry Price

Make all python calls explicitly python2, to avoid any ambiguity when we finally port this to python3