Juju Charms Collection
logstash-forwarder package

Merge lp:~cjwatson/charms/trusty/logstash-forwarder/fix-logrotate-perms into lp:~canonical-is-sa/charms/trusty/logstash-forwarder/trunk

  1. Trusty Tahr (14.04)
  2. fix-logrotate-perms
  3. Merge into trunk
Proposed by Colin Watson
Status: Merged
Approved by: Haw Loeung
Approved revision: 24
Merged at revision: 24
Proposed branch: lp:~cjwatson/charms/trusty/logstash-forwarder/fix-logrotate-perms
Merge into: lp:~canonical-is-sa/charms/trusty/logstash-forwarder/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
hooks/hooks.py (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/charms/trusty/logstash-forwarder/fix-logrotate-perms
Reviewer Review Type Date Requested Status
Haw Loeung Approve
Kristian Glass (community) Approve
Review via email: mp+371641@code.launchpad.net

Commit message

Fix permissions on /etc/logrotate.d/logstash-forwarder.

Description of the change

logrotate ignores executable configuration files:

  $ sudo logrotate -d /etc/logrotate.d/logstash-forwarder
  Ignoring /etc/logrotate.d/logstash-forwarder because of bad file mode.

  Handling 0 logs

To post a comment you must log in.
Revision history for this message
Kristian Glass (doismellburning) :
review: Approve
Revision history for this message
Haw Loeung (hloeung) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/hooks.py'
2--- hooks/hooks.py 2018-04-23 22:00:12 +0000
3+++ hooks/hooks.py 2019-08-22 13:22:12 +0000
4@@ -70,7 +70,7 @@
5 src = os.path.join(charm_dir(), "files", "logstash-forwarder.logrotate")
6 dest = "/etc/logrotate.d/logstash-forwarder"
7 shutil.copyfile(src, dest)
8- os.chmod(dest, 0755)
9+ os.chmod(dest, 0644)
10
11 def writeSSL():
12 if not os.path.exists(conf.configDir()):

Subscribers

People subscribed via source and target branches

to all changes: