Merge lp:~cjwatson/charms/trusty/rutabaga/squid-rsync-ids into lp:~canonical-launchpad-branches/charms/trusty/rutabaga/devel

Proposed by Colin Watson
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~cjwatson/charms/trusty/rutabaga/squid-rsync-ids
Merge into: lp:~canonical-launchpad-branches/charms/trusty/rutabaga/devel
Diff against target: 12 lines (+2/-0)
1 file modified
templates/rutabaga-rsync.j2 (+2/-0)
To merge this branch: bzr merge lp:~cjwatson/charms/trusty/rutabaga/squid-rsync-ids
Reviewer Review Type Date Requested Status
Colin Watson (community) Disapprove
Review via email: mp+359954@code.launchpad.net

Commit message

Tell rsyncd to use the proxy uid/gid when serving squid-logs.

Description of the change

This is much simpler and IMO more sensible than the current hacks to run squid with umask 022 instead of its default of 027, and will allow dropping those hacks (which become even more awkward with later versions of Ubuntu, and I think would otherwise require sedding init scripts).

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

This is obsolete; we now use the squid-reverseproxy charm, and https://code.launchpad.net/~cjwatson/squid-reverseproxy-charm/+git/squid-reverseproxy-charm/+merge/407908 dealt with making the relevant logs accessible by rsync in a different way.

review: Disapprove

Unmerged revisions

37. By Colin Watson

Tell rsyncd to use the proxy uid/gid when serving squid-logs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/rutabaga-rsync.j2'
2--- templates/rutabaga-rsync.j2 2016-07-05 14:54:01 +0000
3+++ templates/rutabaga-rsync.j2 2018-11-30 20:33:02 +0000
4@@ -7,6 +7,8 @@
5 hosts allow = {{ log_hosts_allow }}
6
7 [squid-logs]
8+ uid = proxy
9+ gid = proxy
10 path = /var/log/squid3
11 comment = Squid Logs
12 list = false

Subscribers

People subscribed via source and target branches

to all changes: