Merge lp:~cjwatson/charms/trusty/turnip/neater-logrotate into lp:~canonical-launchpad-branches/charms/trusty/turnip/devel
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merge reported by: | Colin Watson |
Merged at revision: | not available |
Proposed branch: | lp:~cjwatson/charms/trusty/turnip/neater-logrotate |
Merge into: | lp:~canonical-launchpad-branches/charms/trusty/turnip/devel |
Diff against target: |
51 lines (+0/-6) 1 file modified
templates/turnip-logrotate.j2 (+0/-6) |
To merge this branch: | bzr merge lp:~cjwatson/charms/trusty/turnip/neater-logrotate |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+277940@code.launchpad.net |
Commit message
Rotate logs even if empty.
Description of the change
On qastaging, we've ended up with packbackendserver logs back to June, which I thought was a bit weird since I only intended to keep 90 days of logs when I wrote the logrotate configuration here. I then realised that this is because qastaging is pretty quiet and so goes whole days sometimes without a request getting as far as the pack backend server. I think it would be more consistent if we rotated logs even when empty, which will cause "rotate 90" to have a stable effect rather than having a retention period that depends on service activity levels.
To post a comment you must log in.
Merged into the git conversion instead:
https:/ /git.launchpad. net/~canonical- launchpad- branches/ charms/ +source/ turnip/ commit/ ?id=bb979ae81c1 100655b90029924 9194bb22743cc3