~cjwatson/interface-pgsql:fix-readiness-check-v2

Branch merges

Propose for merging

Merged into interface-pgsql:master at revision 70d2da57d24b207797b8edfc66680f40a0526fbd

Tom Haddon: Approve on 2023-03-16

Guillermo Gonzalez (community): Approve on 2023-03-03

Diff: 160 lines (+45/-26)

3 files modified

requires.py (+14/-10)
tox.ini (+4/-0)
unit_tests/test_requires.py (+27/-16)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

70d2da5... by Colin Watson on 2023-03-16

Make commands_pre compatible with tox 3

ac3c26b... by Colin Watson on 2023-03-15

Fix unit tests following cross-model relation support

Commit 133726c646b31d63cf5c33e73322598ba1012b07 broke
`TestConnectionStringConstructor`, since `_cs` now works a bit
differently. Fix the tests to cope.

997402b... by Colin Watson on 2023-03-15

Document CHARM_DIR requirements for running tests

7c0be54... by Colin Watson on 2023-03-15

Fix unit readiness check for v2 protocol

Commit 133726c646b31d63cf5c33e73322598ba1012b07 broke the readiness
check in `ConnectionStrings._authorized` when using the v2 protocol
(used particularly by proxies), because `self[name]` is only populated
usefully for units using the v1 protocol. The previous code essentially
seemed to be checking the bottom half of the `_cs` function, so I split
that out into a new function and arranged to call it directly to avoid
them getting out of sync again.

The unit tests seem to have bitrotted and I couldn't figure out how to
get them to run, but I've tested this with direct relations to the
`postgresql` charm, and Guillermo Gonzalez has tested this using the
`external-services` charm which acts as a proxy.

c35ef4a... by Stuart Bishop on 2018-12-04

Ensure 'changed' flags are set in upgrade-charm

f8b6006... by Stuart Bishop on 2018-10-24

Do not repeatedly reset states after departing relation

Addresses lp:1798118

38c2d4b... by Stuart Bishop on 2018-08-23

ConnectionStrings.standbys should never return None

6e39748... by Stuart Bishop on 2018-07-18

Avoid calling provider handlers before relation exists

81b9fc6... by Stuart Bishop on 2018-06-29

Add and document 'changed' flags. Update docs for modern charms.reactive.

4fca56a... by Stuart Bishop on 2018-05-25

Update maintainer