launchpad-bastion-scripts

Merge ~cjwatson/launchpad-bastion-scripts:ignore-haproxy-queue-depth-checks into launchpad-bastion-scripts:main

  1. Git
  2. lp:~cjwatson/launchpad-bastion-scripts
  3. ignore-haproxy-queue-depth-checks
  4. Merge into main
Proposed by Colin Watson
Status: Merged
Merged at revision: 15bbe3c5db7fe1d0d9fe02e6aeda6a592e001220
Proposed branch: ~cjwatson/launchpad-bastion-scripts:ignore-haproxy-queue-depth-checks
Merge into: launchpad-bastion-scripts:main
Diff against target: 16 lines (+6/-1)
1 file modified
upgrade-production (+6/-1)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+447523@code.launchpad.net

Commit message

Ignore haproxy queue depth checks for production deployments

Description of the change

This doesn't mean that we should ignore them in general, just that they shouldn't block deployments.

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) wrote :

How will we make sure we won't ignore them? Should we add in the documentation a note to check these specifically and raise them in the ~is chat or similar?

review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

I think we'll need to update the nagiprom definitions in lp:canonical-is-prometheus. I filed https://warthogs.atlassian.net/browse/LP-1296 for this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/upgrade-production b/upgrade-production
2index 9c6a5a1..da01057 100755
3--- a/upgrade-production
4+++ b/upgrade-production
5@@ -1,5 +1,10 @@
6 #! /bin/sh
7 set -e
8
9+# Ignore haproxy queue depth checks for deployment purposes: they may need
10+# to be handled by IS, but are unlikely to relate very closely to code
11+# deployments.
12+skip_checks=check_haproxy_queue_depth
13+
14 mkdir -p "$HOME/logs"
15-ssh prod-launchpad@is-bastion-ps5.internal autodeploy-trigger prod-launchpad 2>&1 | tee -a "$HOME/logs/$(date +%F).log"
16+ssh prod-launchpad@is-bastion-ps5.internal autodeploy-trigger prod-launchpad EXTRA_SKIP_CHECKS="$skip_checks" 2>&1 | tee -a "$HOME/logs/$(date +%F).log"

Subscribers

People subscribed via source and target branches